zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Alexey I. Froloff" <raorn@altlinux.org>, zsh-workers@zsh.org
Subject: Re: [PATCH] Rewrite of RI (Ruby documentation browser) completion
Date: Wed, 11 Nov 2009 08:21:40 -0800	[thread overview]
Message-ID: <091111082140.ZM29956@torch.brasslantern.com> (raw)
In-Reply-To: <20091111142741.GO11910@altlinux.org>

Looking at zsh-workers/27367 in the archive ...

What's up with the following hunk -- why was "cur" dropped?  Localizing
curcontext is boilerplate completion code.

-local curcontext="$curcontext" state line ret=1
+local context="$curcontext" state line ret=1


The rest looks OK, so I'll commit without that one change, but someone
else should test.


  reply	other threads:[~2009-11-11 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 23:24 Completion for ri (Ruby API reference frontend) Alexey I. Froloff
2009-10-02  8:42 ` Peter Stephenson
2009-10-02 15:27   ` Alexey I. Froloff
2009-10-03  6:44     ` Doug Kearns
2009-11-08 15:08   ` [PATCH] Rewrite of RI (Ruby documentation browser) completion Alexey I. Froloff
2009-11-11 14:27     ` Alexey I. Froloff
2009-11-11 16:21       ` Bart Schaefer [this message]
2009-11-11 21:24         ` Alexey I. Froloff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=091111082140.ZM29956@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=raorn@altlinux.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).