From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26183 invoked by alias); 11 Nov 2009 16:21:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27389 Received: (qmail 12814 invoked from network); 11 Nov 2009 16:21:45 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts) From: Bart Schaefer Message-id: <091111082140.ZM29956@torch.brasslantern.com> Date: Wed, 11 Nov 2009 08:21:40 -0800 In-reply-to: <20091111142741.GO11910@altlinux.org> Comments: In reply to "Alexey I. Froloff" "Re: [PATCH] Rewrite of RI (Ruby documentation browser) completion" (Nov 11, 5:27pm) References: <200910020842.n928gq54006094@news01.csr.com> <1257692913-22779-1-git-send-email-raorn@altlinux.org> <20091111142741.GO11910@altlinux.org> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "Alexey I. Froloff" , zsh-workers@zsh.org Subject: Re: [PATCH] Rewrite of RI (Ruby documentation browser) completion MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Looking at zsh-workers/27367 in the archive ... What's up with the following hunk -- why was "cur" dropped? Localizing curcontext is boilerplate completion code. -local curcontext="$curcontext" state line ret=1 +local context="$curcontext" state line ret=1 The rest looks OK, so I'll commit without that one change, but someone else should test.