From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21843 invoked from network); 23 Jul 2021 20:11:16 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Jul 2021 20:11:16 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1627071076; b=Oz5WwhgkPHhkeC/pBu5otx1kwKb3+qboNdF01ZuORjGzlnbFKTeBylLC96Is06RW3kQnkozTHA t6M/bE3UZjV70zaylWxN40DbAiyw7t+/0C4CR+4WOBN7UhlckhAGTV4Btyk009NGMWHAu8Eav+ sTiIRH1zaYiD3H8lGP/+3oT3oHw1NXgtONiwg7Jq2TZmA73OXTrpzj7OBQpQb1jNr7ue6GK9PR g79i14WK/+F1VC2bBf9vDhrTpR6SM+DA1dsFlmvTWLdMmagDvWZa8FxS6lc6IR+fCEcDC1WgIA SRm0LpRobIC9AZFRZckFg4+pcdsFDGWFqHS6qx+KlP1DOw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq5.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.100; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1627071076; bh=c6wtlDHJgjX2hFHfoY9HpgJ9FlM7AUoZmSNiFPjuBbo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:MIME-Version:Content-Type: References:In-Reply-To:Date:To:From:Subject:Message-ID:DKIM-Signature: DKIM-Signature; b=Q+0IJ7l9CcUw4gAIuQUc8z9PA7lu4imo1QLA3CB4bK57ffzJi2Ht8HGn/+awepGV490RS+Wp4t hn/15T+49AdIE5R0m8kt0CH6xYVFPD47s8sayzLnBR480mHJ7NBMyXYMVCQBdYPdwYJZftgOJ4 HdulJeLDdouc51K50ASDuvyeDXS925xhO42v0Iu6Q0pwHsw34uIt3I6orovou1rz1tr6F80iYG U/Ik0kKGgnldedDspA778/dlpfT+4Nj+EXtA6RspS4mLhBs2keCl7WPQavqKgZKbOSIemKF3lR mNUdZcu1Sh7G8yUeRM/1GiOSvisTaHFzwBLixxWIe2ISww==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Mime-Version:Content-Type:References:In-Reply-To:Date:To:From:Subject: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=6/kt3dXngNIGYyEeC5vJY02oQ8fRmXyIqj5aPQqaaYI=; b=tozjXPEB9h8l10KjiYX9+IVisP PNyD3H4enzMPRv1l7q64qsgqYWp+mkAXTWamchipqd/hivHvO1csdj2q2cZn9sQ/Y1TCwCvuttxDo ygin91+DlQE0Bct4dDWlwmrh5hN/XqEiGnP1w1VdVqV3c8MSDeyzTOJi0sbUZzBHd8anqNr+bQIop Zwg1TtPgNjQfyCxHSR7PZ8TWwBmQUzCe69L2qB1t4iu/LF6qc3+InOKjjTNxtWs1wZnNf+yGZSrqN kdY6/WnQDyKAEBzIOyNuU7ZUALW4jF4ImH/KLspldlssp38kDF+wTUpsgYJ7kvn5Wvo4SqshjyxFa JZEY3J5g==; Received: from authenticated user by zero.zsh.org with local id 1m71Vs-0005rB-8F; Fri, 23 Jul 2021 20:11:16 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq5.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.100; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq5.tb.ukmail.iss.as9143.net ([212.54.57.100]:34958) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) id 1m71Vf-0005Xt-LG; Fri, 23 Jul 2021 20:11:04 +0000 Received: from [212.54.57.111] (helo=csmtp7.tb.ukmail.iss.as9143.net) by smtpq5.tb.ukmail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1m71Vf-0007PC-Bq for zsh-workers@zsh.org; Fri, 23 Jul 2021 22:11:03 +0200 Received: from pws-Zeus ([86.7.189.51]) by cmsmtp with ESMTPA id 71Vfmbec2feJb71Vfm74my; Fri, 23 Jul 2021 22:11:03 +0200 X-Originating-IP: [86.7.189.51] X-Authenticated-Sender: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.4 cv=YcreWydf c=1 sm=1 tr=0 ts=60fb2257 cx=a_exe a=mDzK/eG20+r+ucIvzJc7BQ==:117 a=mDzK/eG20+r+ucIvzJc7BQ==:17 a=IkcTkHD0fZMA:10 a=e_q4qTt1xDgA:10 a=HYshxDoSAAAA:8 a=pGLkceISAAAA:8 a=sVpGwPLKnZ4LSdiv79wA:9 a=QEXdDO2ut3YA:10 a=elyKgWIyZ5oA:10 a=Plg5eiIisSYA:10 a=na7qQM7zoEAPfvOk0o6d:22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com; s=meg.feb2017; t=1627071063; bh=6/kt3dXngNIGYyEeC5vJY02oQ8fRmXyIqj5aPQqaaYI=; h=Subject:From:To:Date:In-Reply-To:References; b=kJrqUodojzHpIIuqfRbt+eKaTShE/nLm5HB7kmil/S7BiJuObgrVMCDjeakVjYIIK aE/D9yPJiCfbSHO642IrSSOFBidtSX4GLbWe+bILFjjTiD2mNsFoEtx0c8/vV3NfIc RbQo9IrxstNCf1aBaGq/Lb28x0lqZuVJ0xfK7dCIgxD0c/WrkEUO3jmN1frFbRAasI qUFXb5gxQfGehFjsF4q26abkRMQOUoHFOWanNGv8u+G3ePvhSasO1eDrwYZ5xufXdm tpYtk+UTAUtFlesnoVxPZo++//DgB61C0KHL/XkanF9MYaB5OrVbdkiVTSLZhQg0nM 9qOLn8Suc2ZGA== Message-ID: <095e9856b97d176bac61d95aafc4bf77c7d32c28.camel@ntlworld.com> Subject: Re: [PATCH] Do not send duplicate signals when MONITOR is set From: Peter Stephenson To: zsh-workers@zsh.org Date: Fri, 23 Jul 2021 21:11:02 +0100 In-Reply-To: <1738413043.259738.1626688803466@mail2.virginmedia.com> References: <20210607172753.222432-1-epaulson10@gmail.com> <823a57a39d8873ce30d2806d95a1c540cf0fe2f2.camel@ntlworld.com> <1738413043.259738.1626688803466@mail2.virginmedia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfEnzlqJeazWp8SFpnU7reiwbLiSTYMtycH0Uer1qAWaikyP5hxMm28rAAY+A0RMwPvkrx5oIjTgFByXe3svOwZhADZ8YUqVqKgH5aniezwDsEvDTTg29 gWZG5JX6aF71ZwaQJmofvnBXg83LMRhmt0eUuK9fnHwu3MeVzr68ufLf1MRtqATVqEnB6hc1W0eRLA== X-Seq: 49190 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, 2021-07-19 at 11:00 +0100, Peter Stephenson wrote: > > On 18 July 2021 at 23:55 Lawrence Velázquez wrote: > > On Mon, Jun 14, 2021, at 3:19 PM, Peter Stephenson wrote: > > > On Mon, 2021-06-07 at 11:45 -0700, Bart Schaefer wrote: > > > > On Mon, Jun 7, 2021 at 10:28 AM Erik Paulson wrote: > > > > > > > > > > I run emacs as a daemon and use the emacsclient program to connect to > > > > > it. I noticed that when I suspended the emacsclient program and > > > > > resumed it in zsh, the program would sporadically crash. After digging > > > > > into the code, I realized that emacsclient was receiving two SIGCONTs, > > > > > which caused it to send a malformed command to the daemon. > > > > > > > > > > I found that this return used to be present, but was removed in > > > > > https://www.zsh.org/mla/workers/2018/msg01338.html while addressing > > > > > another emacs issue. > > > > ... > > > I would hazard that as SIGCONT is probably the most difficult case --- > > > the only one where you specifically want the process to be running > > > afterwards --- if this patch improves things there, it's prohably not > > > doing a lot of harm in most cases. > > > > ... > > Anything else on this? > > Unless anyone can point to a fundamental error in my summary above, I > suggest we apply this and and see what happens. At the absolute least, > I'm pretty sure we're not going to get any further without trying it > out in earnest, and looking for remaining oddities. I've committed this, so we should keep a look out for missing signals, though they're going to be in very obscure contexts even if there are any. pws