From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42190-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10463 invoked by alias); 30 Dec 2017 18:33:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42190
Received: (qmail 14083 invoked by uid 1010); 30 Dec 2017 18:33:51 -0000
X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-4.server.virginmedia.net by f.primenet.com.au (envelope-from <p.w.stephenson@ntlworld.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(80.0.253.68):SA:0(-1.9/5.0):. 
 Processed in 10.357359 secs); 30 Dec 2017 18:33:51 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
X-Envelope-From: p.w.stephenson@ntlworld.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
X-Originating-IP: [82.132.226.250]
X-Authenticated-User: p.w.stephenson@ntlworld.com
X-Spam: 0
X-Authority: v=2.1 cv=S9Iku9YP c=1 sm=1 tr=0 a=BIwcX7KdjWCWw9TudZeVVA==:117
 a=BIwcX7KdjWCWw9TudZeVVA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10
 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=x7bEGLp0ZPQA:10 a=q2GGsy2AAAAA:8
 a=DZ8UdfIEAAAA:8 a=rM1OFbyBhIapTCPJQjYA:9 a=QEXdDO2ut3YA:10
 a=z9dJwno5l634igLiVhy-:22 a=Ourar-E0_0Or-eGVwG_B:22
Date: Sat, 30 Dec 2017 18:26:25 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <CAH+w=7Y0ATw8DY3_yHtRqXXSrTAruFJi_uV=dKtrGOXCViCYHQ@mail.gmail.com>
References: <etPan.5a47b193.2c35fec7.13d7@zdharma.org> <CAH+w=7Y0ATw8DY3_yHtRqXXSrTAruFJi_uV=dKtrGOXCViCYHQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] zsystem flock: zclose descriptor after unsuccessful lock
To: zsh-workers@zsh.org,Bart Schaefer <schaefer@brasslantern.com>,"zsh-workers@zsh.org" <zsh-workers@zsh.org>
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
Message-ID: <0CDB3904-854B-45E9-BC61-1A637DFF7BEF@ntlworld.com>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ntlworld.com;
	s=meg.feb2017; t=1514658394;
	bh=hmWC7nZ/Ca++XBTaV5z5Sp27KyNJ7Ae1hatt7JJY6gg=;
	h=Date:In-Reply-To:References:Subject:To:From;
	b=YFU5pAyIfMbxETodqQGMiYATG834jLC74xy3bCVJfsldKfz3+cuBdY+Ferw2v1trM
	 0z1XWqHJ74biFShzsh1/Yk9xgWF4zYa6lQyzQV4v0hBkRwluaqKQER0rB07l5rMY2J
	 SdFMwAC/sXBqpDfeVWFebeJzZQeYKlhIAu80aeqgwPO1wbIY6zmmf26M3eucL5l2ao
	 6whpH4cpMh3P+e4KE1uMaXzsl1nIv4NYyUnybDK6fDl7OMmhM0NILIksc/FOQd7IyZ
	 /ozDChJ8sPkFwv9eWFxznnc9yvOADPKaHuwPowhLL2/oFyiBGUPPSvqkgH+gu/2KCI
	 ZHj3Hansnmu6A==

Not very online at the moment so please excuse format but I think you'll fi=
nd there's somewhere a test so we don't output messages when errflag is alr=
eady set (but it could be in some other code path than the one you're talki=
ng about)=2E

pws

On 30 December 2017 17:44:28 GMT+00:00, Bart Schaefer <schaefer@brasslante=
rn=2Ecom> wrote:
>On Sat, Dec 30, 2017 at 7:32 AM, Sebastian Gniazdowski
><psprint@zdharma=2Eorg> wrote:
>> The patch adds preceding zclose(flock_fd) to all return 1 and return
>2 code paths=2E
>
>Nothing wrong with the patch but the original code structure looks
>funny=2E  Why do we return without calling zwarnnam() when errflag?  I
>suppose the assumption is that it only gets set if we already output
>some other error message?

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E