From: Peter Stephenson <pws@cambridgesiliconradio.com>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: TRAPZERR() in chpwd()
Date: Tue, 02 May 2000 10:19:42 +0100 [thread overview]
Message-ID: <0FTX00MAGDWUAU@la-la.cambridgesiliconradio.com> (raw)
In-Reply-To: "Your message of Mon, 01 May 2000 17:37:56 EDT." <20000501173756.B11940@tdc134.comm.mot.com>
Paul Ackersviller wrote:
> I believe the change must've come after 3.1.6, since it exhibits the same
> behaviour as 3.0.7 in my experience. It's only 3.1.7-pre-1 and (some?)
> development versions leading up to it.
Right, I think it's the wordcode stuff. I'm pretty sure I spent some time
(possibly more than once...) getting this right a fair while ago.
Sven, can you confirm that this is the right fix before I commit it? Or if
not, what is, because this can't be too far away from the right answer.
It seems to work with all the basic tests I've tried.
Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.5
diff -u -r1.5 exec.c
--- Src/exec.c 2000/04/10 09:18:27 1.5
+++ Src/exec.c 2000/05/02 09:15:33
@@ -836,7 +836,8 @@
code = *state->pc++;
next = state->pc + WC_SUBLIST_SKIP(code);
}
- if (wc_code(code) != WC_SUBLIST) {
+ if (wc_code(code) != WC_SUBLIST ||
+ WC_SUBLIST_TYPE(code) == WC_SUBLIST_END) {
/* We've skipped to the end of the list, not executing *
* the final pipeline, so don't perform error handling *
* for this sublist. */
@@ -861,7 +862,8 @@
code = *state->pc++;
next = state->pc + WC_SUBLIST_SKIP(code);
}
- if (wc_code(code) != WC_SUBLIST) {
+ if (wc_code(code) != WC_SUBLIST ||
+ WC_SUBLIST_TYPE(code) == WC_SUBLIST_END) {
/* We've skipped to the end of the list, not executing *
* the final pipeline, so don't perform error handling *
* for this sublist. */
--
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK Tel: +44 (0)1223 392070
next prev parent reply other threads:[~2000-05-02 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20000428161546.A8208@tdc134.comm.mot.com>
[not found] ` <1000429044220.ZM30544@candle.brasslantern.com>
[not found] ` <20000501131328.A11940@tdc134.comm.mot.com>
[not found] ` <1000501182216.ZM13391@candle.brasslantern.com>
2000-05-01 21:37 ` Paul Ackersviller
2000-05-02 9:19 ` Peter Stephenson [this message]
2000-05-02 11:15 Sven Wischnowsky
2000-05-02 12:01 ` Peter Stephenson
2000-05-02 12:28 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0FTX00MAGDWUAU@la-la.cambridgesiliconradio.com \
--to=pws@cambridgesiliconradio.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).