zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@cambridgesiliconradio.com>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: Wordcode functions with empty bodies
Date: Wed, 14 Jun 2000 15:03:04 +0100	[thread overview]
Message-ID: <0FW5001QLDP31M@la-la.cambridgesiliconradio.com> (raw)
In-Reply-To: "Your message of Wed, 14 Jun 2000 13:20:28 BST." <0FW5001JJ8Y41M@la-la.cambridgesiliconradio.com>

> If you can
> find a particular chunk of code which seems to be doing something wrong
> (shorter than the complete traps test) I'll have a look at it sometime.

While I'm waiting, there's something obviously wrong with the way exit
tests are unset, but this looks too simple to be the source of everyone's
problems --- which generically stem from the fact that traps can take two
forms which are stored in the same place but manipulated in different ways.

Index: Src/signals.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/signals.c,v
retrieving revision 1.7
diff -u -r1.7 signals.c
--- Src/signals.c	2000/06/09 14:40:54	1.7
+++ Src/signals.c	2000/06/14 12:40:24
@@ -837,9 +837,9 @@
 	    exitfn = removehashnode(shfunctab, "TRAPEXIT");
 	} else {
 	    exitfn = sigfuncs[SIGEXIT];
-	    sigfuncs[SIGEXIT] = NULL;
 	}
-	unsettrap(SIGEXIT);
+	sigfuncs[SIGEXIT] = NULL;
+	sigtrapped[SIGEXIT] = 0;
     }
 
     if (savetraps) {

-- 
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


  reply	other threads:[~2000-06-14 14:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-06-14  6:14 Sven Wischnowsky
2000-06-14 12:20 ` Peter Stephenson
2000-06-14 14:03   ` Peter Stephenson [this message]
2000-06-14 14:23 ` Bart Schaefer
  -- strict thread matches above, loose matches on Subject: below --
2000-06-15  8:12 Sven Wischnowsky
2000-06-14 14:36 Sven Wischnowsky
2000-06-14 14:28 Sven Wischnowsky
2000-06-14 15:08 ` Peter Stephenson
2000-06-14 15:17   ` Peter Stephenson
2000-06-14 16:17   ` Bart Schaefer
2000-06-14 21:55     ` Peter Stephenson
2000-06-13 16:31 Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0FW5001QLDP31M@la-la.cambridgesiliconradio.com \
    --to=pws@cambridgesiliconradio.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).