From: Peter Stephenson <pws@cambridgesiliconradio.com>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list),
Rob Egelink <rob@rambo.its.tudelft.nl>
Subject: Re: PATCH: Re: jobs command in precmd
Date: Thu, 29 Jun 2000 10:41:58 +0100 [thread overview]
Message-ID: <0FWW00BGWTLY9D@la-la.cambridgesiliconradio.com> (raw)
In-Reply-To: "Your message of Thu, 29 Jun 2000 10:25:42 BST." <0FWW00BFDSUU9D@la-la.cambridgesiliconradio.com>
I wrote:
> > Maybe simply saving and restoring stopmsg when executing
> > precmd would be enough.
>
> This seems to be OK; here's the patch for the latest code in CVS. I'll
> send a patch for 3.0.8, too.
here it is... there's no CHECK_JOBS option here.
> + /*
> + * Save stopmsg, since user doesn't get a chance to respond
> + * to a list of jobs generated in precmd.
> + */
This wasn't really true, of course, since you get precmd just before the
command. But I think it's reasonable to expect some conscious action on
the part of the user before overriding the check.
--- Src/utils.c.old Thu Jun 29 10:25:58 2000
+++ Src/utils.c Thu Jun 29 10:28:33 2000
@@ -595,8 +595,15 @@
/* If a shell function named "precmd" exists, *
* then execute it. */
- if ((list = getshfunc("precmd")))
+ if ((list = getshfunc("precmd"))) {
+ /*
+ * Save stopmsg since the user should type `jobs' themself
+ * to turn off the exit check.
+ */
+ int osm = stopmsg;
doshfunc(list, NULL, 0, 1);
+ stopmsg = osm;
+ }
if (errflag)
return;
--
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK Tel: +44 (0)1223 392070
prev parent reply other threads:[~2000-06-29 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20000628113611.A20108@rambo.its.tudelft.nl>
2000-06-28 10:20 ` Peter Stephenson
2000-06-29 9:25 ` PATCH: " Peter Stephenson
2000-06-29 9:41 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0FWW00BGWTLY9D@la-la.cambridgesiliconradio.com \
--to=pws@cambridgesiliconradio.com \
--cc=rob@rambo.its.tudelft.nl \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).