Re: PATCH: compdump (Re: Test hanger disappeared, but ...)

Re: PATCH: compdump (Re: Test hanger disappeared, but ...)

[Sven Wischnowsky]

Bart Schaefer wrote:

> ...
> 
> We seem to be running into a lot of things that cause zsh to abort all
> the way back to top level.  Do other shells give up so thoroughly in
> these situations?

That's interesting... For example, with

  while true; do echo > unwritable; sleep 1; done

zsh stops after the first attempt. bash and ksh don't stop and the
/bin/sh here stops after the first attempt, too.

With

  while true; do echo $(for); sleep 1; done

zsh stops (and prints two error messages!), bash does not stop, but
ksh and /bin/sh do.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: PATCH: compdump (Re: Test hanger disappeared, but ...)

[Peter Stephenson]

Sven wrote:
> That's interesting... For example, with
> 
>   while true; do echo > unwritable; sleep 1; done
> 
> zsh stops after the first attempt. bash and ksh don't stop and the
> /bin/sh here stops after the first attempt, too.
> 
> With
> 
>   while true; do echo $(for); sleep 1; done
> 
> zsh stops (and prints two error messages!), bash does not stop, but
> ksh and /bin/sh do.

These are all perfectly arguable.  In the second case, it's only because
parsing is done before the fork that the shell actually gives up.  If you
attempted to write to an unwritable file in the $(...) it wouldn't stop.  I
don't have any conclusion.

-- 
Peter Stephenson <pws@cambridgesiliconradio.com>
Cambridge Silicon Radio, Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070

PATCH: compdump (Re: Test hanger disappeared, but ...)

[Bart Schaefer]

On Jul 4, 12:29pm, Andrej Borsenkow wrote:
} 
} > When I made my earlier patch for this (12039), I forgot that
} > Test/Modules doesn't get created when the build is static.
} 
} May be, it is something different - but now completion tests do not hang
} anymore.

It looks like compdump failure causes compinit to abort completely when
ZDOTDIR points to a nonexistent location.  The redirection on line 34
prints "no such file or directory" and then everything stops.

We seem to be running into a lot of things that cause zsh to abort all
the way back to top level.  Do other shells give up so thoroughly in
these situations?

Index: Completion/Core/compdump
===================================================================
@@ -21,6 +21,8 @@
 _d_file=${_comp_dumpfile-${0:h}/compinit.dump}.$HOST.$$
 [[ $_d_file = //* ]] && _d_file=${_d_file[2,-1]}
 
+[[ -w ${_d_file:h} ]] || return 1
+
 _d_files=( ${^~fpath:/.}/^([^_]*|*~|*.zwc)(N) )
 
 if [[ -n "$_comp_secure" ]]; then

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net