zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: "Bart Schaefer" <schaefer@brasslantern.com>
Cc: "Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: [PATCH] Change documentation, dedication, loose ends
Date: Sun, 03 Apr 2022 14:18:57 -0500	[thread overview]
Message-ID: <0b4be90c-53b0-4764-83b0-269ebfddbdd2@www.fastmail.com> (raw)
In-Reply-To: <CAH+w=7Y1i68FGUh1DL6whVrJT6SYWgd8Mugfw60yck9Nq5Tz4A@mail.gmail.com>

On Sun 3 Apr 2022, at 11:34, Bart Schaefer wrote:
> I didn't find the rewrite to be significantly clearer than what I
> wrote, but obviously I might be biased.

I'm not sure the CASE_PATHS part itself is clearer, though i did like the
additional reference under NO_CASE_GLOB. Assuming nobody wants to argue
for the rest i think i may commit just that part.

On Sun 3 Apr 2022, at 11:34, Bart Schaefer wrote:
>>  compinit: A "y" response to the "Ignore ... and continue?" prompt removes
>
> It was suggested that we change this prompt, too.  Votes?

Without having looked into it super deeply, 'skip' does seem a little
clearer to me.

On Sun 3 Apr 2022, at 11:34, Bart Schaefer wrote:
>> +Incompatibilities between 5.7.1 and 5.8.1
>
> This seems wrong.  The incompatibilities are either between 5.7.1 and
> 5.8, or between 5.8 and 5.8.1

I didn't really like that either, but i was trying to match the rest of
the file (many instances of that kind of thing). Not sure if there's any
specific precedent for the 5.8 -> 5.8.1 change.

I wouldn't mind documenting somewhere exactly how these files should be
structured. In the mean time, how do you suggest i revise exactly? Would
you prefer each section to cover a single version (5.7.1 -> 5.8,
5.8 -> 5.8.1, 5.8.1 -> 5.9), or...?

On Sun 3 Apr 2022, at 11:34, Bart Schaefer wrote:
> If we're adding a sections specifically for 5.8.1, should the
> line-buffering bug be mentioned?

Is there a behaviour change there? I thought it was just a crash fix

dana


  reply	other threads:[~2022-04-03 19:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03  3:29 dana
2022-04-03  9:23 ` PATCH: _brace_parameter: add (-) Mikael Magnusson
2022-04-03 21:13   ` Mikael Magnusson
2022-04-03 16:34 ` [PATCH] Change documentation, dedication, loose ends Bart Schaefer
2022-04-03 19:18   ` dana [this message]
2022-04-03 20:59     ` Mikael Magnusson
2022-04-08 19:29       ` dana
2022-04-10 21:20         ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b4be90c-53b0-4764-83b0-269ebfddbdd2@www.fastmail.com \
    --to=dana@dana.is \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    --subject='Re: [PATCH] Change documentation, dedication, loose ends' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).