From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21034 invoked by alias); 19 Sep 2016 06:30:35 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39382 Received: (qmail 2430 invoked from network); 19 Sep 2016 06:30:34 -0000 X-Qmail-Scanner-Diagnostics: from mail-wm0-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.54):SA:0(-0.0/5.0):. Processed in 0.346888 secs); 19 Sep 2016 06:30:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: myllynen@redhat.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.54 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:reply-to:subject:references:to:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=vFLOCRyEycRykNrSql9zEXn4wZPXmE6/g8wTth3rm0Q=; b=FryIeFONwX0IeD+3zI2EYl5gXpTaF3WPcEdUAotxkxOwEUalKbRTB1Bj/uFHlH990Q 6ZQYu185TZsADOvHTJA4T4pZgpXT2i5r8KqqrTdZwe/BF+gfw+xD0Dom7s7MzU9x6pCA YyBx++KheXHgbPZyBL+nE6xNW0HsqXmkDMliuIw4VKb1wiemxmkEysBOusTfQBzpPsik CQTp9C3J3lxxhf7reeQPTAhmowiA/quNXi6YBQosgLLZJEELB2Q2AoZZwe2ovVZdWHhk Sfd74HALe4epIxQiNZVvFouAnQkhEKhxlt9EVtnU2tq0QoGs0WCMhq4qP+lepOy2gGQY ZzBA== X-Gm-Message-State: AE9vXwNJyvDmsqIgaFzEK2DGgcCCEDieLipr4kKf//SMwHMDd7gvcQScnrwPOElwsVTKiW2L X-Received: by 10.28.234.157 with SMTP id g29mr5731909wmi.86.1474266279807; Sun, 18 Sep 2016 23:24:39 -0700 (PDT) Reply-To: Marko Myllynen Subject: Re: Zsh OpenStack completions References: <9361ff20-f0f2-9acd-e43e-4b1e2e203531@redhat.com> <20160906233751.GA17896@fujitsu.shahaf.local2> To: zsh workers From: Marko Myllynen Organization: Red Hat Message-ID: <0bbb2428-19f0-4741-10c5-b0c79f9df905@redhat.com> Date: Mon, 19 Sep 2016 09:24:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, On 2016-09-09 09:38, Marko Myllynen wrote: > On 2016-09-07 12:31, Marko Myllynen wrote: >> >> I updated the patch quickly to address some of your comments but based >> on Eric's reply it sounds like we also need to discuss should we >> include these completions in zsh upstream in the first place. > > Here's an updated patch based on initial review comments from Daniel, > most notably more comments added. > > --- > Completion/Unix/Command/_openstack | 189 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 189 insertions(+) > create mode 100644 Completion/Unix/Command/_openstack There were not further comments on this, how should we proceed? I think the lower level technical aspects should be pretty much ok now but does this look like something that would be appropriate for zsh upstream? Thanks, -- Marko Myllynen