From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27361 invoked by alias); 14 Jan 2017 01:43:21 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40355 Received: (qmail 28570 invoked from network); 14 Jan 2017 01:43:21 -0000 X-Qmail-Scanner-Diagnostics: from mout.gmx.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(212.227.15.18):SA:0(-1.9/5.0):. Processed in 1.205365 secs); 14 Jan 2017 01:43:21 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: llua@gmx.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at gmx.com designates 212.227.15.18 as permitted sender) To: zsh-workers@zsh.org From: Eric Cook Subject: [PATCH] Prevent wordsplitting in _mpc lsplaylists Message-ID: <0cea6c6b-4a53-4423-858e-60eb724780b2@gmx.com> Date: Fri, 13 Jan 2017 20:37:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:C7LgjUgWL32nehfWqw1t+5H08KCpivyyiO/Gqb/BLCn8x37gcUY DHj4uA1Qj5VvIGA+mnGT2rOVe7RMHrP4HattUZ3Tw9y0qdaCSwJMezj24OYeKgAZYixRSZa E7mtWzLQRiqQlQb3Uax7aAyxHO5gAAY070QKTPN/hQzVGDy7ZFOBuaSQjqmJhosCYVIoQ1q wDDCXTFPsJi6biv3GdjWw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ycIkGwunI5A=:l5rUjxnYtFDsAIXYOIJlYF s1XUQvNQLKerv/Jb8h4XwxhXLM/VxNkip0EvU4M1ZgABbCsqEi6hB4ncFuRvPfPxeXUn4KgAx HVa+pvGm/wKGUxll6AkGRanh+VqE2dnQE2j/Ki0WHTaTEXXvbQH2UOVwtaqNH0thHXX3qiyH4 jp9rtWFDzr5F4pY8BaPGECItWJiOCVyxE5PYkWS+OlO7fc5KkUWEKUUsjqocmjequJ5k2GFlb epr1rTYhyU6+BjWMyOG+10Op0xsHy2NTnCflyAdq7zymo1bsbM9nENjKSArVchoLJXdrm0Do5 J+TEZHmLhiyBxvd6mPhvsjzymmwo9gxCaimmp/rgqV3XaYmdk8XSMUgUI9yZTtrnNayzpfw1l 0ClzOhzLywNZkLdv1yUplfJqOFKgKAMVIhsv1n+HsiYailjDz5RJxnOrRcBvJQ/voOupdiJoa dYaNzRRDyZAEPFoOup3SIMXNvYMfGG6yYlar98xLqgjiwgiZ7DUjbQNzrNw7qa8uS1O9RAg4w taQbr1DEN6HE4GE8/MB3L4/LwqBJbzRQCZ77Ic9tUxpG/JNx6zhT9883pQU2LTJv+XWu3/fmG oSGBNk3HIp/w9aZPy+uRGse57xviCMJ3aGE6lr6qimlK13UQnoRW0OqFD/w6APRKIdA6L0w9R n+pPedNWbDx6ZtyZCHa1MFBMKwIENcogZ05bHAXvFltOoFFP0oFdi/OK190DSi5eGSu7YqTfg uI8liOtPRlsPJ5yzPP+IFCkk4TX8l9NBojqE/9rSnJEROG5qC2vbyUHV3SQviUDU/wxbBLhyW rhqyQGL A user on irc attempting to submit an patch from a gmail address kept getting delivery failures. So i am submitting on his behalf. --- mpc lsplaylists produces a newline separated list of values which can contain meta-syntactic characters, spaces, and so on. The current code results in wordsplitting in the results if any of the playlists contain spaces. This patch attempts to fix this by splitting the results on newlines instead. Signed-off-by: Earnestly --- Completion/Unix/Command/_mpc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Completion/Unix/Command/_mpc b/Completion/Unix/Command/_mpc index 11eab8463..e0c6888b0 100644 --- a/Completion/Unix/Command/_mpc +++ b/Completion/Unix/Command/_mpc @@ -131,7 +131,7 @@ _mpc_helper_songnumbers() { (( $+functions[_mpc_helper_playlists] )) || _mpc_helper_playlists() { local list expl - list=($(mpc lsplaylists)) + list=(${(f)"$(mpc lsplaylists)"}) _wanted list expl playlist compadd -M $MPC_PLAYLIST_MATCHER $expl -a list } -- 2.11.0