From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: job-control
Date: Mon, 31 Jan 2000 11:52:00 +0000 [thread overview]
Message-ID: <1000131115200.ZM2798@candle.brasslantern.com> (raw)
In-Reply-To: <200001311000.LAA29263@beta.informatik.hu-berlin.de>
On Jan 31, 11:00am, Sven Wischnowsky wrote:
} Subject: Re: PATCH: job-control
}
} > Also, the child_block() call following the unblock in exec.c is redundant,
} > because block/unblock are not stacked and the first thing that waitjobs()
} > does [via waitjob()] is to call child_block().
}
} Yes, I saw that at the weekend, too (I'm playing with a non-recursive
} execution code at home).
}
} if (!(jn->stat & STAT_LOCKED)) {
} child_unblock();
} - child_block();
} waitjobs();
} }
Actually, I just realized that that's not right either. It's not safe to
go on examining jn->stat and jobtab[list_pipe_job] etc. in the rest of
execpline() with child_unblock() in effect (it's left unblocked when
waitjobs() returns).
So we may end up removing the child_unblock() there, but I think we need
to block again after waitjobs().
Index: Src/exec.c
===================================================================
@@ -983,6 +983,7 @@
if (!(jn->stat & STAT_LOCKED)) {
child_unblock();
waitjobs();
+ child_block();
}
if (list_pipe_child &&
jn->stat & STAT_DONE &&
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~2000-01-31 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-01-31 10:00 Sven Wischnowsky
2000-01-31 10:47 ` Bart Schaefer
2000-01-31 11:52 ` Bart Schaefer [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-02-02 8:25 Sven Wischnowsky
2000-02-01 10:58 Sven Wischnowsky
2000-02-01 16:35 ` Bart Schaefer
2000-01-31 12:53 Sven Wischnowsky
2000-01-18 11:36 Sven Wischnowsky
2000-01-29 18:13 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000131115200.ZM2798@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).