* PATCH: Misc. module stuff
@ 2000-03-01 18:21 Bart Schaefer
2000-03-01 18:40 ` Bart Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2000-03-01 18:21 UTC (permalink / raw)
To: zsh-workers
"make check" now fails for statically linked zsh because zpty is not a
standard linked-in module. I can't think of any reasonable fix except
to make the failure somewhat less noisy by attempting to load zpty in
the %prep section of 53completion.ztst.
Then while attempting to get zpty linked in so that I could run the test,
I discovered that INSTALL is somewhat out of date with respect to usage
of mymods.conf, and that adding a mymods.conf did not cause a rebuild of
modules-bltin and its dependents, nor did editing xmods.conf directly.
I added a dummy rule for building mymods.conf so that make won't choke
on a dependency on it for modules-bltin.
Index: INSTALL
===================================================================
@@ -97,6 +97,13 @@
module name per line with no punctuation and no suffix. See the zshmodules
manual page for the list of available modules.
+Note that mymods.conf replaces the standard list of linked-in modules from
+Src/xmods.conf. If you wish to add to the standard list, copy the lines
+that begin with "L " from xmods.conf into mymods.conf and remove the "L "
+from each such line in mymods.conf. Then add the names of other modules
+that you want to link. Module names typically must begin with "zsh/";
+only modules appearing in Src/Aliases/*.mdd may omit the "zsh/" prefix.
+
Note that the modules depending on zle or complete (e.g.: complist and
deltochar) cannot be loaded dynamically on systems which do not allow symbols
in one dynamically loaded library to be visible from another; this is true,
Index: Src/Makefile.in
===================================================================
@@ -128,7 +128,10 @@
# ========== LINKING IN MODULES ==========
-modules-bltin: Makefile
+mymods.conf:
+ @echo Linking with the standard modules.
+
+modules-bltin: Makefile $(sdir)/xmods.conf mymods.conf
if test -f mymods.conf; then \
cat mymods.conf > $@; \
elif test @D@ = N; then \
Index: Test/53completion.ztst
===================================================================
@@ -1,6 +1,7 @@
# Tests for completion system.
%prep
+ zmodload -i zsh/zpty
comptest () { $ZTST_testdir/../Src/zsh -f $ZTST_srcdir/comptest -z $ZTST_testdir/../Src/zsh -d $ZTST_testdir/compdump.tmp "$@" }
Index: Test/comptest
===================================================================
@@ -1,6 +1,6 @@
#!/usr/local/bin/zsh -f
-zmodload zsh/zpty
+zmodload -i zsh/zpty
setopt extendedglob
debug=
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Misc. module stuff
2000-03-01 18:21 PATCH: Misc. module stuff Bart Schaefer
@ 2000-03-01 18:40 ` Bart Schaefer
2000-03-01 19:01 ` Tanaka Akira
0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2000-03-01 18:40 UTC (permalink / raw)
To: zsh-workers
On Mar 1, 6:21pm, Bart Schaefer wrote:
}
} the %prep section of 53completion.ztst.
By the way, when I added 51xtrace.ztst it was not my intention to start
a trend. I think most tests should be numbered *before* 50cd.ztst --
the only reason I chose 51 for xtrace is that it isn't testing an actual
programming construct or user interaction. The tests from 01* to 10*
are sort of marching their way through the manual checking features of
major sections -- for which completion certainly qualifies, even if
zregex does not -- and I didn't want to interrupt that sequence with
something as low-profile as xtrace.
So at some point I think that at least the completion test ought to get
renamed to a lower number.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Misc. module stuff
2000-03-01 18:40 ` Bart Schaefer
@ 2000-03-01 19:01 ` Tanaka Akira
0 siblings, 0 replies; 3+ messages in thread
From: Tanaka Akira @ 2000-03-01 19:01 UTC (permalink / raw)
To: zsh-workers
In article <1000301184015.ZM11824@candle.brasslantern.com>,
"Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
> By the way, when I added 51xtrace.ztst it was not my intention to start
> a trend. I think most tests should be numbered *before* 50cd.ztst --
> the only reason I chose 51 for xtrace is that it isn't testing an actual
> programming construct or user interaction. The tests from 01* to 10*
> are sort of marching their way through the manual checking features of
> major sections -- for which completion certainly qualifies, even if
> zregex does not -- and I didn't want to interrupt that sequence with
> something as low-profile as xtrace.
I see.
> So at some point I think that at least the completion test ought to get
> renamed to a lower number.
I agree.
--
Tanaka Akira
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2000-03-01 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-03-01 18:21 PATCH: Misc. module stuff Bart Schaefer
2000-03-01 18:40 ` Bart Schaefer
2000-03-01 19:01 ` Tanaka Akira
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).