From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Prompt truncation crash
Date: Tue, 21 Mar 2000 18:14:32 +0000 [thread overview]
Message-ID: <1000321181432.ZM7988@candle.brasslantern.com> (raw)
prompttrunc() was using a pointer into the prompt buffer without tracking
realloc()s that might happen in addbufspc().
Index: Src/prompt.c
===================================================================
@@ -733,9 +733,9 @@
prompttrunc(int arg, int truncchar, int doprint, int endchar)
{
if (arg) {
- char ch = *fm, *ptr = bp, *truncstr;
+ char ch = *fm, *ptr, *truncstr;
int truncatleft = ch == '<';
- int w;
+ int w = bp - buf;
/*
* If there is already a truncation active, return so that
@@ -760,10 +760,11 @@
}
if (!*fm)
return 0;
- if (bp == ptr && truncchar == ']') {
+ if (bp - buf == w && truncchar == ']') {
addbufspc(1);
*bp++ = '<';
}
+ ptr = buf + w; /* addbufspc() may have realloc()'d buf */
truncstr = ztrduppfx(ptr, bp - ptr);
bp = ptr;
@@ -787,10 +788,13 @@
if (w < fullen) {
/* Invisible substrings, lots of shuffling. */
int n = strlen(t);
+ char *p = ptr, *q = buf;
addbufspc(n);
+ ptr = buf + (p - q); /* addbufspc() may have realloc()'d */
if (truncatleft) {
- char *p = ptr + n, *q = p;
+ p = ptr + n;
+ q = p;
n = fullen - w;
@@ -812,7 +816,7 @@
bp = q;
} else {
/* Truncate on the right, selectively */
- char *q = ptr + fullen;
+ q = ptr + fullen;
/* First skip over as much as will "fit". */
while (w > 0 && maxlen > 0) {
@@ -846,6 +850,7 @@
/* No invisible substrings. */
if (tlen > fullen) {
addbufspc(tlen - fullen);
+ ptr = bp; /* addbufspc() may have realloc()'d buf */
bp += tlen - fullen;
} else
bp -= fullen - trunclen;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
reply other threads:[~2000-03-21 18:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000321181432.ZM7988@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).