From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: Break annoying make dependency cycle
Date: Tue, 25 Apr 2000 04:10:08 +0000 [thread overview]
Message-ID: <1000425041008.ZM8030@candle.brasslantern.com> (raw)
After weeks of being annoyed when init.o was unexpectedly recompiled, I at
last noticed that zsh always recompiles at least twice whenever there is
a change to any of the .mk or .in files. Try it: With an existing build
tree, run
touch Src/Makefile.in
make
make
You'll see that zsh recreates modules-bltin and consequently recompiles on
the second make, even if it already relinked the zsh binary the first time.
(Maybe this is GNU-make-specific?)
This happens because the first make executes config.status to recreate the
Makefile, but it has already considered modules-bltin to be up to date at
that point -- so it doesn't rebuild *that* until the *second* make, even
though (and because) there's a dependency of modules-bltin on Makefile.
The reason for the dependency of modules-bltin on Makefile appears to be
the reference to the @D@ substitution in the modules-bltin action. To
break this loop and assure that the *first* make really rebuilds anything
that may need rebuilding, the dependency should be on config.status, which
is guaranteed to change any time the @D@ substitution would change.
Almost two hundred times as many words to explain it as to fix it. Whew.
Index: Src/Makefile.in
===================================================================
@@ -137,7 +137,7 @@
cat mymods.conf > $@; \
fi
-modules-bltin:: Makefile $(sdir)/xmods.conf
+modules-bltin:: $(dir_top)/config.status $(sdir)/xmods.conf
if test -f mymods.conf; then \
cat mymods.conf > $@; \
elif test @D@ = N; then \
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
reply other threads:[~2000-04-25 4:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000425041008.ZM8030@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).