From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>,
zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: Re: Seg fault in matcher-list matching
Date: Mon, 15 May 2000 11:44:55 +0000 [thread overview]
Message-ID: <1000515114456.ZM16521@candle.brasslantern.com> (raw)
In-Reply-To: <200005150926.LAA17371@beta.informatik.hu-berlin.de>
On May 15, 11:26am, Sven Wischnowsky wrote:
} Subject: PATCH: Re: Seg fault in matcher-list matching
}
}
} Bart Schaefer wrote:
}
} > I did this:
} >
} > zagzig[41] /u/s/l/z/z4/s/zsh
} > ^cursor over the 4, press TAB
} >
} > The path this was intended to match was /usr/src/local/zsh/zsh-2.4/src/zsh.
} > I had first tried TAB at the end of the line and gotten a feep, in case
} > that matters.
}
} I couldn't get it to seg-fault, but there was something broken. Matching
} of the suffix, for example, and that both in C and shell code.
It doesn't dump for me any more, but I'm still nervous about line 1767 of
compcore.c:
#1 0x80bd798 in addmatches (dat=0xbfffa854, argv=0xbfffa8d8)
at ../../../zsh-3.1.6/Src/Zle/compcore.c:1768
1768 if ((ml = match_str(lsuf, s, &bsl, 0, NULL, 1, 0, 1)) >= 0) {
(gdb) l
1763 else
1764 *argv = NULL;
1765 bcp = lpl;
1766 }
1767 s = dat->psuf ? dat->psuf : "";
1768 if ((ml = match_str(lsuf, s, &bsl, 0, NULL, 1, 0, 1)) >= 0) {
1769 if (matchsubs) {
1770 Cline tmp = get_cline(NULL, 0, NULL, 0, NULL, 0, CLF_SUF);
1771
1772 tmp->suffix = matchsubs;
The reported core dump was caused because match_str() wrote a '\0' byte into
the string pointed to by its second argument [`s' above, `w' in match_str()]
which is being passed as a string constant when dat->psuf == 0. Is that a
potential bug, still?
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~2000-05-15 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-15 9:26 Sven Wischnowsky
2000-05-15 11:44 ` Bart Schaefer [this message]
2000-05-15 12:09 ` seg fault fixed and Makefile change Oliver Kiddle
2000-05-15 22:57 ` PATCH: Re: Seg fault in matcher-list matching Tanaka Akira
2000-05-15 10:43 Sven Wischnowsky
2000-05-15 11:52 Sven Wischnowsky
2000-05-16 10:48 Sven Wischnowsky
2000-05-16 16:03 ` Tanaka Akira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000515114456.ZM16521@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).