From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>,
zsh-workers@sunsite.auc.dk,
Peter Stephenson <pws@cambridgesiliconradio.com>
Subject: Re: PATCH: Re: Segmentation fault 3.1.7-pre-3/4
Date: Tue, 23 May 2000 15:44:54 +0000 [thread overview]
Message-ID: <1000523154455.ZM1095@candle.brasslantern.com> (raw)
In-Reply-To: <200005230831.KAA23545@beta.informatik.hu-berlin.de>
In-Reply-To: <0FV000FFM9H4SI@la-la.cambridgesiliconradio.com>
On May 23, 10:31am, Sven Wischnowsky wrote:
} Subject: PATCH: Re: Segmentation fault 3.1.7-pre-3/4
}
} Bernd Eggink wrote:
}
} > This gives a seg fault if executed in a script:
} >
} > read -q "REPLY?hm: "
} >
} > Happens with pre-3 and pre-4, not with pre-1.
}
} Oh, look Bart, there's the reason to not always use shout (11036).
Hmm, why did I think that SHTTY != -1 mean that shout was nonzero?
I personally would prefer the following patch, but I haven't committed
it yet.
Index: builtin.c
===================================================================
@@ -4970,6 +4970,10 @@
oshout = shout;
init_shout();
}
+ } else if (!shout) {
+ haso = 1;
+ oshout = shout;
+ init_shout();
}
/* We should have a SHTTY opened by now. */
if (SHTTY == -1) {
On May 23, 10:10am, Peter Stephenson wrote:
} Subject: Re: PATCH: Re: Segmentation fault 3.1.7-pre-3/4
}
} Sven wrote
} > But with zle not loaded, the
} >
} > zsh -c "read -q '?Can you see this? '" < /dev/null >& /dev/null
} >
} > from 11036 doesn't show the prompt (but at least it doesn't segv
} > anymore). Is it right or wrong? Do we have to work around it?
}
} Seems to me that after doing your damnedest *not* to have the prompt shown,
} you don't want it. `read -q' is documented as always reading from
} the terminal, and the prompt as printing on stderr. I haven't checked
} that's what's actually going on, but it's consistent.
It's confusing. If I've written a script and embedded a "read -q" in it
somewhere, chances are I expect it to display the prompt and not just
hang mysteriously until the user happens to touch the keyboard. It should
not be necessary to always write something like
[[ -t 2 ]] && read -q '?Can you see this? ' 2>/dev/tty
because the shell knows much better than I do whether there *is* a tty.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~2000-05-23 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-23 8:31 Sven Wischnowsky
2000-05-23 9:10 ` Peter Stephenson
2000-05-23 15:44 ` Bart Schaefer [this message]
2000-05-23 16:10 ` Bart Schaefer
2000-05-27 8:24 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000523154455.ZM1095@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=pws@cambridgesiliconradio.com \
--cc=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).