From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9407 invoked from network); 27 May 2000 08:24:19 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 27 May 2000 08:24:19 -0000 Received: (qmail 26957 invoked by alias); 27 May 2000 08:24:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 11607 Received: (qmail 26950 invoked from network); 27 May 2000 08:24:11 -0000 From: "Bart Schaefer" Message-Id: <1000527082407.ZM21482@candle.brasslantern.com> Date: Sat, 27 May 2000 08:24:06 +0000 In-Reply-To: <1000523161048.ZM1121@candle.brasslantern.com> Comments: In reply to "Bart Schaefer" "Re: PATCH: Re: Segmentation fault 3.1.7-pre-3/4" (May 23, 4:10pm) References: <200005230831.KAA23545@beta.informatik.hu-berlin.de> <0FV000FFM9H4SI@la-la.cambridgesiliconradio.com> <1000523154455.ZM1095@candle.brasslantern.com> <1000523161048.ZM1121@candle.brasslantern.com> X-Mailer: Z-Mail (5.0.0 30July97) To: zsh-workers@sunsite.auc.dk Subject: Re: PATCH: Re: Segmentation fault 3.1.7-pre-3/4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On May 23, 4:10pm, Bart Schaefer wrote: } Subject: Re: PATCH: Re: Segmentation fault 3.1.7-pre-3/4 } } } + } else if (!shout) { } } + haso = 1; } } + oshout = shout; } } + init_shout(); } } } } } What horrible things would happen if `haso' were simply left as 0 here? No one has had anything to say about this, so I've committed the following patch. Index: builtin.c =================================================================== @@ -3406,6 +3406,9 @@ oshout = shout; init_shout(); } + } else if (!shout) { + /* We need an output FILE* on the tty */ + init_shout(); } /* We should have a SHTTY opened by now. */ if (SHTTY == -1) { -- Bart Schaefer Brass Lantern Enterprises http://www.well.com/user/barts http://www.brasslantern.com