zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Peter Stephenson <pws@cambridgesiliconradio.com>,
	zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: Wordcode functions with empty bodies
Date: Wed, 14 Jun 2000 16:17:37 +0000	[thread overview]
Message-ID: <1000614161737.ZM17079@candle.brasslantern.com> (raw)
In-Reply-To: <0FW500762GQFIK@la-la.cambridgesiliconradio.com>

On Jun 14,  4:08pm, Peter Stephenson wrote:
} Subject: Re: Wordcode functions with empty bodies
}
} > Continue, it hits endtrapscode() and from there
} > frees the eprog in sigfuncs[28]. BUT it doesn't reset sigfuncs[28].
} 
} Oh, I see, sorry.  The answer is it should disappear from there at the
} point where it would do with an ordinary (non-function) trap.  [...]
} 
} Ideally this value shouldn't be used anyway, because sigtrapped[SIGWINCH]
} is now clear.  That was a problem in dosavetrap() --- it was correct to
} save the trap, because it needs something to prompt it to delete the local
} trap even if it just unsets it, but it should have checked sigtrapped to
} see if the sigfuncs value was valid.

This has fixed the "prompt bart" crash, though I still don't quite follow
why putting a `:' command in the function body (instead of using an empty
function) prevented the crash before.

However, either Clint's 11839 or my 11857 is still needed to prevent the
crash reported in 11837, so there's still something fishy going on with
saving and restoring the EXIT trap.  Or else the lack of 11857 _is_ the
fishy thing that's going on, but I don't follow how the ZSIG_FUNC bit is
set when there is no function.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


  parent reply	other threads:[~2000-06-14 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-06-14 14:28 Sven Wischnowsky
2000-06-14 15:08 ` Peter Stephenson
2000-06-14 15:17   ` Peter Stephenson
2000-06-14 16:17   ` Bart Schaefer [this message]
2000-06-14 21:55     ` Peter Stephenson
  -- strict thread matches above, loose matches on Subject: below --
2000-06-15  8:12 Sven Wischnowsky
2000-06-14 14:36 Sven Wischnowsky
2000-06-14  6:14 Sven Wischnowsky
2000-06-14 12:20 ` Peter Stephenson
2000-06-14 14:03   ` Peter Stephenson
2000-06-14 14:23 ` Bart Schaefer
2000-06-13 16:31 Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1000614161737.ZM17079@candle.brasslantern.com \
    --to=schaefer@candle.brasslantern.com \
    --cc=pws@cambridgesiliconradio.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).