From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: "Andrej Borsenkow" <Andrej.Borsenkow@mow.siemens.ru>,
"ZSH workers mailing list" <zsh-workers@sunsite.auc.dk>
Subject: Re: PATCH: environment handling rewrite
Date: Fri, 28 Jul 2000 16:30:26 +0000 [thread overview]
Message-ID: <1000728163027.ZM9436@candle.brasslantern.com> (raw)
In-Reply-To: <000501bff870$e1a9a400$21c9ca95@mow.siemens.ru>
On Jul 28, 12:50pm, Andrej Borsenkow wrote:
}
} This rewrites environment handling to use system supplied
} putenv()/getenv() if available.
I would have preferred that putenv/getenv not have been defined as
functions using those names, but rather that there was a new function
named zputenv and that the body of the new getenv had been left in
zgetenv; that is, put #ifdefs inside the bodies of zputenv/zgetenv.
It's probably not a real issue because the #ifdef'd putenv/getenv are
declared static, but in general it's best to avoid redeclaring symbols
that some other library might also decide to redeclare.
Also, minor nit-pick, but I dislike the coding style of putting a space
between a function's name and the opening paren of the parameter list.
I won't repeat "hate" three times, but it's not consistent with the rest
of the zsh style.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2000-07-28 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-28 8:50 Andrej Borsenkow
2000-07-28 9:13 ` Peter Stephenson
2000-07-28 16:30 ` Bart Schaefer [this message]
2000-08-03 12:53 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1000728163027.ZM9436@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=Andrej.Borsenkow@mow.siemens.ru \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).