From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9989 invoked from network); 28 Jul 2000 16:34:17 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 28 Jul 2000 16:34:17 -0000 Received: (qmail 7513 invoked by alias); 28 Jul 2000 16:34:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 12427 Received: (qmail 7506 invoked from network); 28 Jul 2000 16:34:08 -0000 From: "Bart Schaefer" Message-Id: <1000728163027.ZM9436@candle.brasslantern.com> Date: Fri, 28 Jul 2000 16:30:26 +0000 In-Reply-To: <000501bff870$e1a9a400$21c9ca95@mow.siemens.ru> Comments: In reply to "Andrej Borsenkow" "PATCH: environment handling rewrite" (Jul 28, 12:50pm) References: <000501bff870$e1a9a400$21c9ca95@mow.siemens.ru> X-Mailer: Z-Mail (5.0.0 30July97) To: "Andrej Borsenkow" , "ZSH workers mailing list" Subject: Re: PATCH: environment handling rewrite MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jul 28, 12:50pm, Andrej Borsenkow wrote: } } This rewrites environment handling to use system supplied } putenv()/getenv() if available. I would have preferred that putenv/getenv not have been defined as functions using those names, but rather that there was a new function named zputenv and that the body of the new getenv had been left in zgetenv; that is, put #ifdefs inside the bodies of zputenv/zgetenv. It's probably not a real issue because the #ifdef'd putenv/getenv are declared static, but in general it's best to avoid redeclaring symbols that some other library might also decide to redeclare. Also, minor nit-pick, but I dislike the coding style of putting a space between a function's name and the opening paren of the parameter list. I won't repeat "hate" three times, but it's not consistent with the rest of the zsh style. -- Bart Schaefer Brass Lantern Enterprises http://www.well.com/user/barts http://www.brasslantern.com Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net