Re: vared bug

Re: vared bug

[Bart Schaefer]

On Aug 14, 10:02am, Bernd Eggink wrote:
} Subject: Re: vared bug
}
} Thanks, but now a "vared -c prompt var" causes a
} segmentation fault if var is unset...

Could you please give a few more details?  3.0.8 or 3.1.9?

`vared -c prompt var' edits the `prompt' variable, so that can't be what
you actually mean.

`vared -c -p something var' works for me, it prints "something" and waits
for me to enter the value that gets assigned to var.

`vared -p something var' also works for me, it prints the warning message
"no such variable: var".  Both when run from a script and on the command
line, and when executed multiple times, etc.

So I'm confused.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: vared bug

[Bart Schaefer]

On Aug 14, 11:37am, Bernd Eggink wrote:
} Subject: Re: vared bug
}
} Sorry again, what I meant was of course
}     
}     vared -cp prompt var
}     
} where 'var' is unset.

Aha.

I get "BUG: attempt to free storage at invalid address".  It happens at
zsfree() at Src/Zle/zle_main.c line 531.

I don't think this has anything to do with the value of `shout'; it does
not happen in 3.0.8.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

PATCH: Re: vared bug

[Bart Schaefer]

On Aug 14,  4:12pm, Bart Schaefer wrote:
}
} On Aug 14, 11:37am, Bernd Eggink wrote:
} }     
} }     vared -cp prompt var
} }     
} } where 'var' is unset.
} 
} I get "BUG: attempt to free storage at invalid address".  It happens at
} zsfree() at Src/Zle/zle_main.c line 531.

This appears to have come from the changes to remove PERMALLOC/LASTALLOC
and friends.

Index: Src/Zle/zle_main.c
===================================================================
@@ -877,6 +877,8 @@
     } else if (*s) {
 	zwarnnam(name, "invalid parameter name: %s", args[0], 0);
 	return 1;
+    } else {
+	s = ztrdup(s);
     }
 
     if (SHTTY == -1) {


-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net