From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: "Andrej Borsenkow" <Andrej.Borsenkow@mow.siemens.ru>,
"Zsh hackers list" <zsh-workers@sunsite.auc.dk>
Subject: Re: PATCH: ptyread eating CPU on Cygwin
Date: Wed, 18 Oct 2000 15:55:47 +0000 [thread overview]
Message-ID: <1001018155547.ZM4463@candle.brasslantern.com> (raw)
In-Reply-To: <001301c038f6$e114c940$21c9ca95@mow.siemens.ru>
On Oct 18, 3:30pm, Andrej Borsenkow wrote:
}
} O.K., this is very simple patch that makes ptyread use select. Sven,
} could you look at conditions there?
I'm not Sven, but HAVE_SELECT does not imply having FD_ZERO or an fd_set
typedef.
On the other hand, I've just noticed that other code assumes in several
places that it does imply those things, so it's probably OK.
However, using a NULL timeout structure in the select() call has turned a
non-blocking read into a fully blocking one. If you're going to do that,
you might as well throw out the select() call and just set the descriptor
back to blocking state before calling read(). I suspect there's a good
reason it was a non-blocking read in the first place, though.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2000-10-18 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-17 16:56 Andrej Borsenkow
2000-10-18 9:04 ` Peter Stephenson
2000-10-18 11:30 ` PATCH: " Andrej Borsenkow
2000-10-18 15:55 ` Bart Schaefer [this message]
2000-10-18 16:44 ` Andrej Borsenkow
2000-10-19 8:45 Sven Wischnowsky
2000-10-19 9:49 ` Andrej Borsenkow
2000-10-19 14:24 ` Bart Schaefer
2000-10-20 7:01 Sven Wischnowsky
2000-10-20 7:55 ` Andrej Borsenkow
2000-10-23 7:59 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1001018155547.ZM4463@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=Andrej.Borsenkow@mow.siemens.ru \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).