* script using vared to read commands - history bug
@ 2000-10-20 4:13 Greg Klanderman
2000-10-20 7:57 ` Bart Schaefer
0 siblings, 1 reply; 5+ messages in thread
From: Greg Klanderman @ 2000-10-20 4:13 UTC (permalink / raw)
To: Zsh list
If I run the following script:
#!/bin/zsh
prompt="%B%%%b "
while cmd="" && vared -h -p "$prompt" cmd ; do
echo " -- got: $cmd"
print -s - "$cmd"
done
it works as intended, except that the most recent
command never appears in the history. What's up?
thank,
Greg
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: script using vared to read commands - history bug
2000-10-20 4:13 script using vared to read commands - history bug Greg Klanderman
@ 2000-10-20 7:57 ` Bart Schaefer
[not found] ` <14832.44455.892766.386987@phl.itasoftware.com>
0 siblings, 1 reply; 5+ messages in thread
From: Bart Schaefer @ 2000-10-20 7:57 UTC (permalink / raw)
To: greg, Zsh list
On Oct 20, 12:13am, Greg Klanderman wrote:
}
} If I run the following script:
}
} #!/bin/zsh
}
} prompt="%B%%%b "
} while cmd="" && vared -h -p "$prompt" cmd ; do
} echo " -- got: $cmd"
} print -s - "$cmd"
} done
}
} it works as intended, except that the most recent
} command never appears in the history. What's up?
What's up is that the history code doesn't really expect to be invoked
from a non-interactive shell, even though `vared -h' will let you get
away with it, so nothing is properly initialized until the second time
you write something to the history, and thereafter it's always off by
one.
If the first thing you do at the prompt in this script is type ctrl-p,
zsh 3.1.9 will core dump. (3.0.8 doesn't seem to have that part of the
problem.)
If there's a straightforward solution to this, I don't know enough about
the history mechanism to find it quickly. There are a number of places
in zle_hist.c that never check to see whether quietgethist() returns 0
(which is what produces the core dump), but it's not merely that the
history is empty, because you don't get a core dump at the first prompt
from `zsh -f'.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: script using vared to read commands - history bug
@ 2000-10-20 7:12 Sven Wischnowsky
2000-10-20 8:00 ` Bart Schaefer
0 siblings, 1 reply; 5+ messages in thread
From: Sven Wischnowsky @ 2000-10-20 7:12 UTC (permalink / raw)
To: zsh-workers
Greg Klanderman wrote:
> If I run the following script:
>
> #!/bin/zsh
>
> prompt="%B%%%b "
> while cmd="" && vared -h -p "$prompt" cmd ; do
> echo " -- got: $cmd"
> print -s - "$cmd"
> done
>
> it works as intended, except that the most recent
> command never appears in the history. What's up?
Another one of the things that have been fixed in the meantime.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2000-10-21 3:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-10-20 4:13 script using vared to read commands - history bug Greg Klanderman
2000-10-20 7:57 ` Bart Schaefer
[not found] ` <14832.44455.892766.386987@phl.itasoftware.com>
2000-10-21 3:01 ` PATCH: " Bart Schaefer
2000-10-20 7:12 Sven Wischnowsky
2000-10-20 8:00 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).