zsh-workers
 help / color / mirror / code / Atom feed
* PATCH: Another _comp_options entry
@ 2000-11-05  3:08 Bart Schaefer
  0 siblings, 0 replies; 2+ messages in thread
From: Bart Schaefer @ 2000-11-05  3:08 UTC (permalink / raw)
  To: zsh-workers

_path_files gets pretty confused if bareglobqual isn't set.  What worries me
is that if someone actually is using nobareglobal, _path_files may attempt
to merge its list of qualifiers with something the user didn't intend to
have treated as qualifiers.

Index: Completion/Core/compinit
===================================================================
@@ -123,6 +123,7 @@
 # The standard options set in completion functions.
 
 _comp_options=(
+       bareglobqual
        nullglob
        rcexpandparam
        extendedglob

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Another _comp_options entry
@ 2000-11-08  9:53 Sven Wischnowsky
  0 siblings, 0 replies; 2+ messages in thread
From: Sven Wischnowsky @ 2000-11-08  9:53 UTC (permalink / raw)
  To: zsh-workers


Bart Schaefer wrote:

> _path_files gets pretty confused if bareglobqual isn't set. 

Oops.

> What worries me
> is that if someone actually is using nobareglobal, _path_files may attempt
> to merge its list of qualifiers with something the user didn't intend to
> have treated as qualifiers.

Hrm. Yes. Of course we would need to save the old setting of that
option in a parameter and make the test in _path_files:151 look at it.

That could then make us think about saving the settings of all
options. In an array or assoc.

And that could make us think about allowing selectively completing
only (un|)set options in _options, based on a style. And get rid of
_(un|)set_options.

Hm. Copying option settings isn't as expensive anymore as it once was.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2000-11-08  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-11-05  3:08 PATCH: Another _comp_options entry Bart Schaefer
2000-11-08  9:53 Sven Wischnowsky

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).