Re: signal queueing (was: Re: Last patch)

["Bart Schaefer" <schaefer@candle.brasslantern.com>]

On Dec 11, 10:50am, Sven Wischnowsky wrote:
} 
} Here is what I have now (not to be committed yet).

One bug I spotted:

} diff -u -r ../oz/Src/module.c ./Src/module.c
} --- ../oz/Src/module.c	Sun Dec 10 10:14:27 2000
} +++ ./Src/module.c	Sun Dec 10 20:52:51 2000
} @@ -967,22 +988,24 @@
}  	zwarnnam(nam, "-e cannot be combined with other options", NULL, 0);
}  	return 1;
}      }
} +    queue_signals();
}      if (ops['e'])
} -	return bin_zmodload_exist(nam, args, ops);
} +	ret = bin_zmodload_exist(nam, args, ops);
}      else if (ops['d'])
} -	return bin_zmodload_dep(nam, args, ops);
} +	ret = bin_zmodload_dep(nam, args, ops);
}      else if ((ops['a'] || ops['b']) && !(ops['c'] || ops['p'] || ops['f']))
} -	return bin_zmodload_auto(nam, args, ops);
} +	ret = bin_zmodload_auto(nam, args, ops);
}      else if (ops['c'] && !(ops['b'] || ops['p']))
} -	return bin_zmodload_cond(nam, args, ops);
} +	ret = bin_zmodload_cond(nam, args, ops);
}      else if (ops['f'] && !(ops['b'] || ops['p']))
} -	return bin_zmodload_math(nam, args, ops);
} +	ret = bin_zmodload_math(nam, args, ops);
}      else if (ops['p'] && !(ops['b'] || ops['c']))
} -	return bin_zmodload_param(nam, args, ops);
} +	ret = bin_zmodload_param(nam, args, ops);
}      else if (!(ops['a'] || ops['b'] || ops['c'] || ops['p']))
} -	return bin_zmodload_load(nam, args, ops);
} +	ret = bin_zmodload_load(nam, args, ops);
}      else
}  	zwarnnam(nam, "use only one of -b, -c, or -p", NULL, 0);
} +    unqueue_signals();
}  
}      return 1;
}  }

That last return should be `return ret;'.

More commentary later, if I come up with any.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net