Bug with ZLE special variables and traps?

Bug with ZLE special variables and traps?

[Bart Schaefer]

Hey, zsh-workers:  Is this a recently-introduced bug?  Why is PREBUFFER
empty in a signal handler at patchlevel 1.4940 when it is not at 1.4705?


On Mar 22, 10:42am, Nadav Har'El wrote:
} Subject: Re: Append cancelled commands to history
}
} On Sat, Mar 20, 2010, Bart Schaefer wrote about "Re: Append cancelled commands to history":
} > 
} > Hmm.  When I use TRAPINT, $PREBUFFER is always empty.
} > 
} > torch% print $ZSH_VERSION $ZSH_PATCHLEVEL 
} > 4.3.10-dev-1 1.4940
} 
} Thanks for the explanations. For me, $PREBUFFER does work:
} 
} $ print $ZSH_VERSION $ZSH_PATCHLEVEL
} 4.3.10 1.4705
} $ cat /etc/redhat-release; rpm -qf =zsh
} Fedora release 12 (Constantine)
} zsh-4.3.10-4.fc12.x86_64
} 
} $ functions TRAPINT
} TRAPINT () {
}         zle && [[ $HISTNO -eq $HISTCMD ]] && print -s -r -- "$PREBUFFER$BUFFER"
}         echo "prebuffer: '$PREBUFFER'"
}         return $1
} }
} 
} $ for i in *
} for> do
} for> echo<INTERRUPT>prebuffer: 'for i in *
} do
} '
} 
} $

torch% echo $ZSH_VERSION $ZSH_PATCHLEVEL
4.3.10-dev-1 1.4940
torch% TRAPINT () {
function> zle && [[ $HISTNO -eq $HISTCMD ]] && print -s -r -- "$PREBUFFER$BUFFER"
function> echo "prebuffer: '$PREBUFFER'"
function> return $1
function> }
torch% for i in *
for> do
for> echoprebuffer: ''

torch% 

Re: Bug with ZLE special variables and traps?

[Peter Stephenson]

On Mon, 22 Mar 2010 07:57:03 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Hey, zsh-workers:  Is this a recently-introduced bug?  Why is PREBUFFER
> empty in a signal handler at patchlevel 1.4940 when it is not at 1.4705?

It's actually a wonder this every worked.  The internal current history
line is used at multiple lexical stack depths and is not guaranteed to be
the same as any line that's going to be read back as a stored line to be
executed from the command line.  Until recently we've been lax in hiding it
when it should be invalid.

As we say in WiFi embedded software, WDIAHTBSC?

Index: Src/hist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/hist.c,v
retrieving revision 1.96
diff -p -u -r1.96 hist.c
--- Src/hist.c	18 Dec 2009 19:50:45 -0000	1.96
+++ Src/hist.c	22 Mar 2010 16:03:29 -0000
@@ -164,6 +164,22 @@ mod_export char *hptr;
 /**/
 mod_export char *chline;
 
+/*
+ * The current history line as seen by ZLE.
+ * We modify chline for use in other contexts while ZLE may
+ * still be running; ZLE should see only the top-level value.
+ *
+ * To avoid having to modify this every time we modify chline,
+ * we set it when we push the stack, and unset it when we pop
+ * the appropriate value off the stack.  As it's never modified
+ * on the stack this is the only maintainance we ever do on it.
+ * In return, ZLE has to check both zle_chline and (if that's
+ * NULL) chline to get the current value.
+ */
+
+/**/
+mod_export char *zle_chline;
+
 /* true if the last character returned by hgetc was an escaped bangchar *
  * if it is set and NOBANGHIST is unset hwaddc escapes bangchars        */
 
Index: Src/lex.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/lex.c,v
retrieving revision 1.53
diff -p -u -r1.53 lex.c
--- Src/lex.c	4 Jan 2010 12:21:09 -0000	1.53
+++ Src/lex.c	22 Mar 2010 16:03:29 -0000
@@ -249,6 +249,13 @@ lexsave(void)
     ls->histdone = histdone;
     ls->stophist = stophist;
     stophist = 0;
+    if (!lstack) {
+	/* top level, make this version visible to ZLE */
+	zle_chline = chline;
+	/* ensure line stored is NULL-terminated */
+	if (hptr)
+	    *hptr = '\0';
+    }
     ls->hline = chline;
     chline = NULL;
     ls->hptr = hptr;
@@ -355,6 +362,11 @@ lexrestore(void)
     errflag = 0;
 
     ln = lstack->next;
+    if (!ln) {
+	/* Back to top level: don't need special ZLE value */
+	DPUTS(chline != zle_chline, "BUG: Ouch, wrong chline for ZLE");
+	zle_chline = NULL;
+    }
     free(lstack);
     lstack = ln;
 }
Index: Src/Zle/zle_params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_params.c,v
retrieving revision 1.33
diff -p -u -r1.33 zle_params.c
--- Src/Zle/zle_params.c	13 Mar 2009 10:04:21 -0000	1.33
+++ Src/Zle/zle_params.c	22 Mar 2010 16:03:29 -0000
@@ -334,8 +334,19 @@ get_rbuffer(UNUSED(Param pm))
 static char *
 get_prebuffer(UNUSED(Param pm))
 {
-    if (chline)
+    /*
+     * Use the editing current history line, not necessarily the
+     * history line that's currently in the history mechanism
+     * since our line may have been stacked.
+     */
+    if (zle_chline) {
+	/* zle_chline was NULL terminated when pushed onto the stack */
+	return dupstring(zle_chline);
+    }
+    if (chline) {
+	/* hptr is valid */
 	return dupstrpfx(chline, hptr - chline);
+    }
     return dupstring("");
 }
 
Index: Src/Zle/zle_tricky.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_tricky.c,v
retrieving revision 1.101
diff -p -u -r1.101 zle_tricky.c
--- Src/Zle/zle_tricky.c	7 Dec 2009 21:40:11 -0000	1.101
+++ Src/Zle/zle_tricky.c	22 Mar 2010 16:03:29 -0000
@@ -632,16 +632,16 @@ docomplete(int lst)
     origline = dupstring(zlemetaline);
     origcs = zlemetacs;
     origll = zlemetall;
-    if (!isfirstln && chline != NULL) {
-	/* If we are completing in a multi-line buffer (which was not  *
-	 * taken from the history), we have to prepend the stuff saved *
-	 * in chline to the contents of line.                          */
-
+    if (!isfirstln && (chline != NULL || zle_chline != NULL)) {
 	ol = dupstring(zlemetaline);
-	/* Make sure that chline is zero-terminated. */
-	*hptr = '\0';
+	/*
+	 * Make sure that chline is zero-terminated.
+	 * zle_chline always is and hptr doesn't point into it anyway.
+	 */
+	if (!zle_chline)
+	    *hptr = '\0';
 	zlemetacs = 0;
-	inststr(chline);
+	inststr(zle_chline ? zle_chline : chline);
 	chl = zlemetacs;
 	zlemetacs += ocs;
     } else
-- 
Peter Stephenson <pws@csr.com>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

Re: Bug with ZLE special variables and traps?

[Peter Stephenson]

On Mon, 22 Mar 2010 16:07:16 +0000
Peter Stephenson <pws@csr.com> wrote:
> --- Src/lex.c	4 Jan 2010 12:21:09 -0000	1.53
> +++ Src/lex.c	22 Mar 2010 16:03:29 -0000
> @@ -249,6 +249,13 @@ lexsave(void)
>      ls->histdone = histdone;
>      ls->stophist = stophist;
>      stophist = 0;
> +    if (!lstack) {
> +	/* top level, make this version visible to ZLE */
> +	zle_chline = chline;
> +	/* ensure line stored is NULL-terminated */
> +	if (hptr)
> +	    *hptr = '\0';
> +    }
>      ls->hline = chline;
>      chline = NULL;
>      ls->hptr = hptr;

Oops... I was getting random crashes and valgrind says hptr can be
non-NULL when chline has been freed, which is asking for trouble.

Index: Src/hist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/hist.c,v
retrieving revision 1.97
diff -p -u -r1.97 hist.c
--- Src/hist.c	22 Mar 2010 16:25:59 -0000	1.97
+++ Src/hist.c	22 Mar 2010 23:11:32 -0000
@@ -1171,7 +1171,7 @@ hend(Eprog prog)
     if (histactive & HA_NOINC) {
 	zfree(chline, hlinesz);
 	zfree(chwords, chwordlen*sizeof(short));
-	chline = NULL;
+	chline = hptr = NULL;
 	chwords = NULL;
 	histactive = 0;
 	unqueue_signals();
@@ -1286,7 +1286,7 @@ hend(Eprog prog)
     }
     zfree(chline, hlinesz);
     zfree(chwords, chwordlen*sizeof(short));
-    chline = NULL;
+    chline = hptr = NULL;
     chwords = NULL;
     histactive = 0;
     if (isset(SHAREHISTORY)? histfileIsLocked() : isset(INCAPPENDHISTORY))

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/