From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22904 invoked by alias); 31 Aug 2010 06:58:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 28217 Received: (qmail 14473 invoked from network); 31 Aug 2010 06:58:03 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts) From: Bart Schaefer Message-id: <100830235750.ZM6368@torch.brasslantern.com> Date: Mon, 30 Aug 2010 23:57:48 -0700 In-reply-to: Comments: In reply to Nikolai Weibull "Re: [PATCH] _git: Add completion for help subcommand" (Aug 30, 8:59pm) References: <1282393263-16767-1-git-send-email-aaron@schrab.com> <100830094359.ZM7722@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: [PATCH] _git: Add completion for help subcommand MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Aug 30, 8:59pm, Nikolai Weibull wrote: } Subject: Re: [PATCH] _git: Add completion for help subcommand } } > On Aug 26, 9:55am, Nikolai Weibull wrote: } } > } ( --b --c)--a } > } (--a --c)--b } > } (--a --b )--c } } What I never "understood" was why the standard form wasn't to use a } variable in this case. I mean, the difference is that you exclude the } current option, which is of course excluded by itself (unless its } defined as being able to appear many times). Hmm. I'm not certain, now that you mention it. The functions that use the above form are generally some of the earliest completions that were ever written (or were cribbed from those early ones), so it may be that at one point in the past it was a problem to exclude the same option one was defining, e.g., (--a)--a would break. If that's not currently the case [I don't know either way] then you're right, one might as well use the style with the variable. --