zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: segfault on menu-select
Date: Sun, 05 Sep 2010 21:11:47 -0700	[thread overview]
Message-ID: <100905211147.ZM10043@torch.brasslantern.com> (raw)
In-Reply-To: <20100831143337.GA1108@uni-due.de>

On Aug 31,  4:33pm, Philipp Hartwig wrote:
} Subject: Re: segfault on menu-select
}
} > The difference seems to be whether the zsh/compctl module is loaded.  I
} > don't immediately know why zsh/compctl would be necessary for proper
} > execution of menu-select, but if I add
} > 
} > zmodload zsh/compctl
} > 
} > to the minimal zshrc, I am no longer able to force a crash.

Hmm, and hmm again.  (Yes, I'm hmm-ing at my own previous remarks.)

} I also do not experience any more crashes since adding
} 
} zmodload zsh/compctl
} 
} to my .zshrc. Unfortunately this breaks the menu-select feature in some 
} cases.

I've been fooling with this a bit, and it's not broken; the best I can
describe it is to say it's just not ready to start yet.

} [in a directory with files baz-foo and test-foo and compctl not loaded]
} 
} ph% vi foo<tab><tab><ctrl-o>
} 
} will work out nice and give me the desired menu-selection (or crash).  
} But if I [zmodload zsh/compctl as well], no menu-select will 
} take place anymore.

I can reproduce this.  However, menu-select will take place for me if I
simply add one more TAB:

torch% vi foo<tab><tab><tab><ctrl-o>

This comes down to the code passing through the "else" branch at lines
1013 - 1025 of Src/Zle/compcore.c -- with compctl not loaded, dat.lst
is 0 after runhookdef(COMPCTLMAKEHOOK, ...), but with compctl loaded
dat.list becomes nonzero if we have not made a third attempt to allow
compctl to perform default completion of -foo.

Now, what this has to do with the crash (not) happening after we have
passed (or not) through the compctl hooks, I still don't follow.


  reply	other threads:[~2010-09-06  4:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 14:46 Philipp Hartwig
2010-08-12 14:53 ` Frank Terbeck
2010-08-12 15:20   ` Philipp Hartwig
2010-08-12 15:49     ` Frank Terbeck
2010-08-12 16:53       ` Philipp Hartwig
2010-08-12 17:07         ` Frank Terbeck
2010-08-12 17:33           ` Philipp Hartwig
2010-08-12 18:04             ` Frank Terbeck
2010-08-12 23:07             ` Bart Schaefer
2010-08-13  8:08               ` Philipp Hartwig
2010-08-13 15:57                 ` Bart Schaefer
2010-08-13 20:43                   ` Peter Stephenson
2010-08-15 20:43                     ` Bart Schaefer
2010-08-15 22:34                       ` Bart Schaefer
2010-08-31 14:33                         ` Philipp Hartwig
2010-09-06  4:11                           ` Bart Schaefer [this message]
2011-01-09 18:56                             ` Philipp Hartwig
2011-01-09 19:54                               ` Bart Schaefer
2011-01-09 20:57                                 ` Philipp Hartwig
2010-08-12 16:04   ` Bart Schaefer
2010-08-12 17:03     ` Philipp Hartwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=100905211147.ZM10043@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).