From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: PATCH: coprocess descriptor and error messages
Date: Thu, 16 Sep 2010 22:04:42 -0700 [thread overview]
Message-ID: <100916220444.ZM30547@torch.brasslantern.com> (raw)
This seems somehow wrong to me ... starting from "zsh -f":
torch% print -p ; echo $?
print: bad file number: -1
1
torch% read -p ; echo $?
1
Seems to me that both commands should either fail silently, or print a
more specific error. Patch below does the former. (Line numbers may
be off.) I won't commit until I see commentary.
Index: Src/builtin.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/builtin.c,v
retrieving revision 1.48
diff -c -r1.48 builtin.c
--- builtin.c 17 Apr 2009 18:57:22 -0000 1.48
+++ builtin.c 17 Sep 2010 05:02:15 -0000
@@ -3677,13 +3720,17 @@
if (OPT_HASARG(ops,'u') || OPT_ISSET(ops,'p')) {
int fd;
- if (OPT_ISSET(ops, 'p'))
+ if (OPT_ISSET(ops, 'p')) {
fd = coprocout;
- else {
+ if (fd < 0)
+ return 1;
+ } else {
char *argptr = OPT_ARG(ops,'u'), *eptr;
/* Handle undocumented feature that -up worked */
if (!strcmp(argptr, "p")) {
fd = coprocout;
+ if (fd < 0)
+ return 1;
} else {
fd = (int)zstrtol(argptr, &eptr, 10);
if (*eptr) {
--
next reply other threads:[~2010-09-17 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 5:04 Bart Schaefer [this message]
2010-09-17 8:46 ` Peter Stephenson
2010-09-17 14:41 ` Bart Schaefer
2010-09-17 16:11 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100916220444.ZM30547@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).