From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: "setopt noexec" and interactive shells
Date: Sun, 25 Mar 2001 23:05:16 +0000 [thread overview]
Message-ID: <1010325230516.ZM11576@candle.brasslantern.com> (raw)
In-Reply-To: <1010325225123.ZM10966@candle.brasslantern.com>
On Mar 25, 10:51pm, Bart Schaefer wrote:
}
} Any comments on this patch?
Ahem. I have my own comment: It doesn't work. I missed another spot
where EXECOPT is tested. Critique the following patch instead.
Index: Src/exec.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-3.1/Src/exec.c,v
retrieving revision 1.128
diff -c -r1.128 exec.c
--- Src/exec.c 2001/03/24 22:19:24 1.128
+++ Src/exec.c 2001/03/25 22:59:12
@@ -1639,7 +1639,7 @@
char *text;
int save[10];
int fil, dfil, is_cursh, type, do_exec = 0, i, htok = 0;
- int nullexec = 0, assign = 0, forked = 0;
+ int nullexec = 0, assign = 0, forked = 0, execopt;
int is_shfunc = 0, is_builtin = 0, is_exec = 0;
/* Various flags to the command. */
int cflags = 0, checked = 0;
@@ -1648,6 +1648,7 @@
Wordcode beg = state->pc, varspc;
FILE *oxtrerr = xtrerr;
+ execopt = !(unset(EXECOPT) && (unset(INTERACTIVE) || !isatty(0)));
doneps4 = 0;
redir = (wc_code(*state->pc) == WC_REDIR ? ecgetredirs(state) : NULL);
if (wc_code(*state->pc) == WC_ASSIGN) {
@@ -2092,7 +2093,7 @@
zwarn("writing redirection not allowed in restricted mode", NULL, 0);
execerr();
}
- if (unset(EXECOPT))
+ if (!execopt)
continue;
switch(fn->type) {
case REDIR_HERESTR:
@@ -2218,7 +2219,7 @@
fputc('\n', xtrerr);
fflush(xtrerr);
}
- } else if (isset(EXECOPT) && !errflag) {
+ } else if (execopt && !errflag) {
/*
* We delay the entersubsh() to here when we are exec'ing
* the current shell (including a fake exec to run a builtin then
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-03-25 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-04 5:20 Bart Schaefer
2001-03-05 1:55 ` Zefram
2001-03-25 22:51 ` Bart Schaefer
2001-03-25 23:05 ` Bart Schaefer [this message]
2001-03-27 18:09 ` Zefram
2001-03-27 19:12 ` Zefram
2001-03-30 6:37 ` Bart Schaefer
2001-03-27 19:18 ` Bart Schaefer
2001-03-27 19:25 ` Zefram
2001-03-27 19:58 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010325230516.ZM11576@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).