From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: PATCH: 3.0.8 Re: PATCH: reverse string subscripting
Date: Thu, 5 Apr 2001 16:15:07 +0000 [thread overview]
Message-ID: <1010405161507.ZM9535@candle.brasslantern.com> (raw)
In-Reply-To: <200104051122.NAA06140@beta.informatik.hu-berlin.de>
On Apr 5, 1:22pm, Sven Wischnowsky wrote:
}
} % a=abcd
} % echo $a[1,(r)d]
}
} didn't work, because it stopped one character too early trying to find
} the matching substring for `d'.
It appears that all 3.0 versions of zsh have this same bug, for both
forward and reverse pattern matches. The third hunk below is just an
optimization (avoid redoing the strlen()).
Index: Src/params.c
===================================================================
--- Src/params.c 2000/09/27 03:18:54 1.1.1.6.4.6
+++ Src/params.c 2001/04/05 16:01:19
@@ -468,12 +468,14 @@
}
return a2 ? -1 : 0;
} else {
+ char *de;
d = getstrvalue(v);
if (!d || !*d)
return 0;
+ de = d + strlen(d);
if (a2) {
if (down)
- for (r = -2, t = d + strlen(d) - 1; t >= d; r--, t--) {
+ for (r = -2, t = de; t >= d; r--, t--) {
sav = *t;
*t = '\0';
if (domatch(d, c, 0) && !--num) {
@@ -482,7 +484,7 @@
}
*t = sav;
} else
- for (r = 0, t = d; *t; r++, t++) {
+ for (r = 0, t = d; t <= de; r++, t++) {
sav = *t;
*t = '\0';
if (domatch(d, c, 0) && !--num) {
@@ -493,11 +495,11 @@
}
} else {
if (down)
- for (r = -1, t = d + strlen(d) - 1; t >= d; r--, t--) {
+ for (r = -1, t = de - 1; t >= d; r--, t--) {
if (domatch(t, c, 0) && !--num)
return r;
} else
- for (r = 1, t = d; *t; r++, t++)
+ for (r = 1, t = d; t < de; r++, t++)
if (domatch(t, c, 0) && !--num)
return r;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-04-05 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-05 11:22 Sven Wischnowsky
2001-04-05 16:15 ` Bart Schaefer [this message]
2001-04-05 18:09 ` Bart Schaefer
2001-04-06 7:35 ` Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010405161507.ZM9535@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).