From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: revert Clint's build patches
Date: Tue, 24 Apr 2001 06:40:44 +0000 [thread overview]
Message-ID: <1010424064044.ZM32389@candle.brasslantern.com> (raw)
In-Reply-To: <Pine.SV4.4.33.0104232341490.18873-200000@itsrm2.mow.siemens.ru>
On Apr 23, 11:44pm, Andrej Borsenkow wrote:
}
} O.K., so here is diff against current CVS that reverts
} Clint's patches (sorry). I commit it when I have article number.
Unfortunately, I'm now able to compile zsh but not link it:
Modules/termcap.o: In function `scantermcap':
/usr/src/local/zsh/zsh-4.0-build/Src/Modules/../../../zsh-4.0/Src/Modules/termcap.c:320:
undefined reference to `boolcodes'
/usr/src/local/zsh/zsh-4.0-build/Src/Modules/../../../zsh-4.0/Src/Modules/termcap.c:329:
undefined reference to `numcodes'
/usr/src/local/zsh/zsh-4.0-build/Src/Modules/../../../zsh-4.0/Src/Modules/termcap.c:338:
undefined reference to `strcodes'
Modules/termcap.o: In function `boot_zshQstermcap':
/usr/src/local/zsh/zsh-4.0-build/Src/Modules/../../../zsh-4.0/Src/Modules/termcap.c:366:
undefined reference to `setupterm'
This appears to happen because the checks to add the library containing
boolcodes, et al. to LIBS were removed, but the checks for whether those
variables are defined and which headers define them were NOT removed.
In any case AC_TRY_COMPILE is the wrong way to detect boolcodes, etc.
AC_TRY_LINK is better; that way even if the header happens to be there,
but the library is not, they won't be marked as available.
The following patch gets my compile and link going, but of course does
not enable $terminfo or echoti on my system, and uses the fallback lists
of capcodes for $termcap. However, I don't know whether to add
AC_SEARCH_LIBS(setupterm, ...)
or
AC_SEARCH_LIBS(tigetstr, ...)
or both.
diff -ru -x CVS zsh-forge/current/Src/Modules/termcap.c zsh-4.0/Src/Modules/termcap.c
--- zsh-forge/current/Src/Modules/termcap.c Sun Apr 22 09:35:16 2001
+++ zsh-4.0/Src/Modules/termcap.c Mon Apr 23 23:28:56 2001
@@ -362,7 +362,7 @@
boot_(Module m)
{
#ifdef HAVE_TGETENT
-# if defined(HAVE_CURSES_H) && defined(HAVE_TERM_H)
+# ifdef HAVE_SETUPTERM
setupterm((char *)0, 1, (int *)0);
# endif
diff -ru -x CVS zsh-forge/current/Src/Modules/terminfo.c zsh-4.0/Src/Modules/terminfo.c
--- zsh-forge/current/Src/Modules/terminfo.c Sun Apr 22 09:35:16 2001
+++ zsh-4.0/Src/Modules/terminfo.c Mon Apr 23 23:29:19 2001
@@ -347,7 +347,9 @@
boot_(Module m)
{
#ifdef HAVE_TIGETSTR
+# ifdef HAVE_SETUPTERM
setupterm((char *)0, 1, (int *)0);
+# endif
if (!createtihash())
return 1;
diff -ru -x CVS zsh-forge/current/configure.in zsh-4.0/configure.in
--- zsh-forge/current/configure.in Mon Apr 23 22:33:56 2001
+++ zsh-4.0/configure.in Mon Apr 23 23:28:42 2001
@@ -516,32 +516,32 @@
AC_SEARCH_LIBS(tgetent, [$termcap_curses_order])
AC_MSG_CHECKING(if boolcodes is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = boolcodes;],
AC_DEFINE(HAVE_BOOLCODES) boolcodes=yes, boolcodes=no)
AC_MSG_RESULT($boolcodes)
AC_MSG_CHECKING(if numcodes is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = numcodes;],
AC_DEFINE(HAVE_NUMCODES) numcodes=yes, numcodes=no)
AC_MSG_RESULT($numcodes)
AC_MSG_CHECKING(if strcodes is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = strcodes;],
AC_DEFINE(HAVE_STRCODES) strcodes=yes, strcodes=no)
AC_MSG_RESULT($strcodes)
AC_MSG_CHECKING(if boolnames is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = boolnames;],
AC_DEFINE(HAVE_BOOLNAMES) boolnames=yes, boolnames=no)
AC_MSG_RESULT($boolnames)
AC_MSG_CHECKING(if numnames is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = numnames;],
AC_DEFINE(HAVE_NUMNAMES) numnames=yes, numnames=no)
AC_MSG_RESULT($numnames)
AC_MSG_CHECKING(if strnames is available)
-AC_TRY_COMPILE([#include <curses.h>
+AC_TRY_LINK([#include <curses.h>
#include <term.h>], [char **test = strnames;],
AC_DEFINE(HAVE_STRNAMES) strnames=yes, strnames=no)
AC_MSG_RESULT($strnames)
@@ -853,7 +853,7 @@
putenv getenv \
brk sbrk \
pathconf sysconf \
- tgetent tigetflag tigetnum tigetstr)
+ tgetent tigetflag tigetnum tigetstr setupterm)
AC_FUNC_STRCOLL
dnl Check if tgetent accepts NULL (and will allocate its own termcap buffer)
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-04-24 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-21 8:37 Zsh broken after the latest " Andrej Borsenkow
2001-04-21 10:51 ` Andrej Borsenkow
2001-04-23 4:53 ` What about this? (was: RE: Zsh broken after the latest build patches) Andrej Borsenkow
2001-04-23 16:24 ` Bart Schaefer
2001-04-23 16:44 ` Peter Stephenson
2001-04-23 17:41 ` Bart Schaefer
2001-04-23 17:58 ` Peter Stephenson
2001-04-23 23:08 ` PATCH: " Clint Adams
2001-04-23 18:00 ` Andrej Borsenkow
2001-04-23 18:22 ` Bart Schaefer
2001-04-23 19:44 ` PATCH: revert Clint's build patches Andrej Borsenkow
2001-04-24 6:40 ` Bart Schaefer [this message]
2001-04-24 8:50 ` Andrej Borsenkow
2001-04-24 5:33 ` PATCH: The last, I really hope, subscripting tweak for a long while Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010424064044.ZM32389@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).