From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: martin.ebourne@arcordia.com, zsh-workers@sunsite.dk
Subject: PATCH: Re: New style completion bug when ctrl-C pressed
Date: Thu, 26 Apr 2001 16:11:53 +0000 [thread overview]
Message-ID: <1010426161153.ZM13644@candle.brasslantern.com> (raw)
In-Reply-To: <OF5BC3F04A.D43CF126-ON80256A3A.00531685@uk.jpmorgan.com>
On Apr 26, 4:37pm, martin.ebourne@arcordia.com wrote:
}
} There appears to be a bug in the new style completion system whereby if you
} abort the completion with Ctrl-C (as I often do if the machine is not
} readily responding) it doesn't clear up after itself properly.
}
} The cause would appear to be that a shell function is at some point
} temporarily defined to override the builtin compadd - and this gets left
} around.
Try this. (Doesn't seem worthwhile to do the same for _complete_help, but
maybe we should consider it.)
diff -ru zsh-forge/current/Completion/Base/Completer/_approximate zsh-4.0/Completion/Base/Completer/_approximate
--- zsh-forge/current/Completion/Base/Completer/_approximate Mon Apr 2 04:05:44 2001
+++ zsh-4.0/Completion/Base/Completer/_approximate Thu Apr 26 09:03:30 2001
@@ -61,6 +61,7 @@
# fi
builtin compadd "$_correct_expl[@]" "$@"
}
+ trap '[[ -n "$redef" ]] && unfunction compadd' EXIT INT
fi
_comp_correct=1
@@ -92,7 +93,6 @@
[[ "$compstate[list]" != list* ]] &&
compstate[list]="$compstate[list] force"
fi
- [[ -n "$redef" ]] && unfunction compadd
compstate[pattern_match]="$opm"
return 0
@@ -102,7 +102,6 @@
(( _comp_correct++ ))
done
-[[ -n "$redef" ]] && unfunction compadd
compstate[pattern_match]="$opm"
return 1
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-04-26 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-26 15:37 martin.ebourne
2001-04-26 16:11 ` Bart Schaefer [this message]
2001-04-26 17:32 ` PATCH: " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010426161153.ZM13644@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=martin.ebourne@arcordia.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).