PATCH: cygwin stat code (again)

PATCH: cygwin stat code (again)

[Peter Stephenson]

I sent this before, but it seems to have gorn.  I believe we've been having
problems with outgoing mail and it doesn't seem to be in the mailing list
archive.

mflags in stat under cygwin shouldn't be const, since it needs to be
initialised at run time.

Index: Src/Modules/stat.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/stat.c,v
retrieving revision 1.3
diff -u -r1.3 stat.c
--- Src/Modules/stat.c	2001/04/30 10:40:51	1.3
+++ Src/Modules/stat.c	2001/05/10 11:43:06
@@ -54,15 +54,15 @@
     }
     if (flags & STF_STRING) {
 	static const char *modes = "?rwxrwxrwx";
-	static const mode_t mflags[9] = {
 #ifdef __CYGWIN__
-	    0
+	static mode_t mflags[9] = { 0 };
 #else
+	static const mode_t mflags[9] = {
 	    S_IRUSR, S_IWUSR, S_IXUSR,
 	    S_IRGRP, S_IWGRP, S_IXGRP,
 	    S_IROTH, S_IWOTH, S_IXOTH
-#endif
 	};
+#endif
 	const mode_t *mfp = mflags;
 	char pm[11];
 	int i;

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

RE: PATCH: cygwin stat code (again)

[Andrej Borsenkow]

> 
> mflags in stat under cygwin shouldn't be const, since it needs to be
> initialised at run time.
> 

Was not this already fixed?

2001-04-30  Andrej Borsenkow <bor@zsh.org>

        * Bart: 14144 (modified): Src/Modules/stat.c: The S_IXUSR,
        S_IXGRP, S_IXOTH are made external variables in Cygwin 1.3.1 and
        cannot be used as static array initializer anymore.

-andrej

Re: PATCH: cygwin stat code (again)

[Bart Schaefer]

On May 12,  9:32am, Andrej Borsenkow wrote:
} Subject: RE: PATCH: cygwin stat code (again)
}
} > mflags in stat under cygwin shouldn't be const, since it needs to be
} > initialised at run time.
} 
} Was not this already fixed?

PWS made a different change; his patch made

	static const mode_t mflags[9]

into

	static mode_t mflags[9]

whereas my patch changed the values within the array.  I should have
caught that the `const' needed to go away too.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: PATCH: cygwin stat code (again)

[Christopher Faylor]

In article <1010512104101.ZM6168@candle.brasslantern.com>,
Bart Schaefer <schaefer@candle.brasslantern.com> wrote:
>On May 12,  9:32am, Andrej Borsenkow wrote:
>} Subject: RE: PATCH: cygwin stat code (again)
>}
>} > mflags in stat under cygwin shouldn't be const, since it needs to be
>} > initialised at run time.
>} 
>} Was not this already fixed?
>
>PWS made a different change; his patch made
>
>	static const mode_t mflags[9]
>
>into
>
>	static mode_t mflags[9]
>
>whereas my patch changed the values within the array.  I should have
>caught that the `const' needed to go away too.

FWIW, I've been convinced that this change to Cygwin caused many more
problems than it solved so it has been reverted in 1.3.2.

FYI,
cgf

Re: PATCH: cygwin stat code (again)

[Bart Schaefer]

On May 26,  5:37pm, Christopher Faylor wrote:
} Subject: Re: PATCH: cygwin stat code (again)
}
} FWIW, I've been convinced that this change to Cygwin caused many more
} problems than it solved so it has been reverted in 1.3.2.

Anyone think we should back out the Src/Modules/stat.c changes?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: PATCH: cygwin stat code (again)

[Peter Stephenson]

"Bart Schaefer" wrote:
> On May 26,  5:37pm, Christopher Faylor wrote:
> } Subject: Re: PATCH: cygwin stat code (again)
> }
> } FWIW, I've been convinced that this change to Cygwin caused many more
> } problems than it solved so it has been reverted in 1.3.2.
> 
> Anyone think we should back out the Src/Modules/stat.c changes?

I'd say we remove this for 4.1, or maybe even some later 4.0, when the
Cygwin changes make this obsolete.  It's not actually breaking anything at
the moment, is it?

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

RE: PATCH: cygwin stat code (again)

[Andrej Borsenkow]

>
> "Bart Schaefer" wrote:
> > On May 26,  5:37pm, Christopher Faylor wrote:
> > } Subject: Re: PATCH: cygwin stat code (again)
> > }
> > } FWIW, I've been convinced that this change to Cygwin caused many more
> > } problems than it solved so it has been reverted in 1.3.2.
> >
> > Anyone think we should back out the Src/Modules/stat.c changes?
>
> I'd say we remove this for 4.1, or maybe even some later 4.0, when the
> Cygwin changes make this obsolete.

It is already changed back in released cygwin-1.3.2.

  It's not actually breaking anything at
> the moment, is it?
>

No, but the less system-dependent code we have the better (espicially when
this code is not needed).

Of course, somebody may have 1.3.1 (the only version that has this problem)
and try to compile zsh, but the usual policy on cygwin list was "update your
cygwin installation" anyway.

-andrej