zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Peter Stephenson <pws@csr.com>,
	zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: test on Cygwin
Date: Mon, 21 May 2001 14:20:33 +0000	[thread overview]
Message-ID: <1010521142034.ZM10406@candle.brasslantern.com> (raw)
In-Reply-To: <Tc0a88d0153a7894b59@mailsweeper01.cambridgesiliconradio.com>

On May 21, 11:30am, Peter Stephenson wrote:
} Subject: PATCH: test on Cygwin
}
} +  touch unmodish
} +  chmod 000 unmodish
}    [[ -r zerolength && ! -r unmodish ]]
} +  # This works around a bug in rm -f in some versions of Cygwin
} +  chmod 644 unmodish
}  0:-r cond

That can't be right.  The test condition (`0:') depends on the test
case itself (`[[ -r ... ]]') being the last thing executed.

This is what the %clean section is for, no?

I won't yet commit the following in case I'm missing something really
obvious ...

--- zsh-forge/current/Test/C02cond.ztst	Mon May 21 07:13:53 2001
+++ zsh-4.0/Test/C02cond.ztst	Mon May 21 07:18:19 2001
@@ -19,6 +19,8 @@
   chmod u+s modish
   chmod +t modish
 
+  touch unmodish
+  chmod 000 unmodish
 %test
 
   [[ -a zerolength && ! -a nonexistent ]]
@@ -68,11 +70,7 @@
   [[ -p pipe && ! -p zerolength ]]
 0:-p cond
 
-  touch unmodish
-  chmod 000 unmodish
   [[ -r zerolength && ! -r unmodish ]]
-  # This works around a bug in rm -f in some versions of Cygwin
-  chmod 644 unmodish
 0:-r cond
 
   [[ -s nonzerolength && ! -s zerolength ]]
@@ -151,3 +149,7 @@
 
   [ `echo 0` -lt `echo 1` ]
 0:substituion in `[' builtin
+
+%clean
+  # This works around a bug in rm -f in some versions of Cygwin
+  chmod 644 unmodish

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


  reply	other threads:[~2001-05-21 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-21 10:30 Peter Stephenson
2001-05-21 14:20 ` Bart Schaefer [this message]
2001-05-21 15:37   ` Peter Stephenson
2001-05-22 10:21 ` Andrej Borsenkow
2001-05-22 10:31   ` Andrej Borsenkow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1010521142034.ZM10406@candle.brasslantern.com \
    --to=schaefer@candle.brasslantern.com \
    --cc=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).