* A tweak to magic-space
@ 2001-05-28 5:23 Bart Schaefer
0 siblings, 0 replies; only message in thread
From: Bart Schaefer @ 2001-05-28 5:23 UTC (permalink / raw)
To: zsh-workers
I believe I mentioned this in a previous posting ...
I've been using this function:
magic-space() {
[[ "$LBUFFER" = (|*[^\\])!\"* ]] && zle .self-insert || zle .magic-space
}
zle -N magic-space
This means that if the current input line contains !" to the left of the
insertion point, history is not expanded upon typing a space.
This is all very well and good, but it makes using `set -x' an incredible
pain, because the trace of the above function keeps popping out in place of
every space I type. (Maybe we need an inverse of `typeset -ft' ... though,
oddly, execution tracing set only with `typeset -ft' does NOT happen when
widgets are called directly by ZLE, which is probably a bug.)
The following patch puts the equivalent of the above into the C code. I
won't commit it until after 4.0.1 is released, unless enough somebodies
say I should. However, if any of you try it, I could use some feedback
on whether it's better to test for !" only in LBUFFER, or whether to test
all of $BUFFER (that is, drop the `bangq + 2 > line + cs' test in the C
version). I go back and forth ...
--- zsh-forge/current/Src/Zle/zle_tricky.c Thu May 17 08:48:46 2001
+++ zsh-4.0/Src/Zle/zle_tricky.c Thu May 24 01:15:32 2001
@@ -2239,9 +2239,13 @@
int
magicspace(char **args)
{
+ char *bangq;
int ret;
c = ' ';
- if (!(ret = selfinsert(args)))
+ for (bangq = (char *)line; (bangq = strchr(bangq, bangchar)); bangq += 2)
+ if (bangq[1] == '"' && (bangq == (char *)line || bangq[-1] != '\\'))
+ break;
+ if (!(ret = selfinsert(args)) && (!bangq || bangq + 2 > (char *)line + cs))
doexpandhist();
return ret;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-05-28 5:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-05-28 5:23 A tweak to magic-space Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).