From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15046 invoked from network); 30 May 2001 15:32:28 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 30 May 2001 15:32:28 -0000 Received: (qmail 22680 invoked by alias); 30 May 2001 15:32:22 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 14571 Received: (qmail 22667 invoked from network); 30 May 2001 15:32:21 -0000 From: "Bart Schaefer" Message-Id: <1010530152958.ZM1164@candle.brasslantern.com> Date: Wed, 30 May 2001 15:29:58 +0000 In-Reply-To: <20010530100001.A27922@dman.com> Comments: In reply to Clint Adams "Re: termcap bug on Linux" (May 30, 10:00am) References: <1010529160507.ZM13557@candle.brasslantern.com> <000001c0e8d1$33b431b0$21c9ca95@mow.siemens.ru> <20010530100001.A27922@dman.com> X-Mailer: Z-Mail (5.0.0 30July97) To: ZSH Workers Mailing List Subject: Re: termcap bug on Linux MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On May 30, 10:00am, Clint Adams wrote: } Subject: Re: termcap bug on Linux } } I'm fine with the consistency. I just think that an unconditional } reliance on NCURSES_VERSION being set is going to lead to trouble. Back in 13987 you wrote: } ncurses 4.2's tgetflag() will return ERR (-1) if called with an } argument not found in boolcodes. ncurses 5.2's tgetflag() will return } 0, a la Solaris. The test in termcap.c is #if !defined(NCURSES_VERSION) || !defined(COLOR_PAIR) COLOR_PAIR is defined in ncurses 4.2, so apparently this behavior has bounced back and forth with different versions of ncurses. So it looks as if a configure test may be the safest approach, but it might be OK to test (NCURSES_MAJOR_VERSION < 5). I'm going to commit 14516 as it is, and then look at this a bit more. -- Bart Schaefer Brass Lantern Enterprises http://www.well.com/user/barts http://www.brasslantern.com Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net