zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: PATCH: "make check" with libzsh (e.g. FreeBSD)
Date: Sat, 2 Jun 2001 15:49:09 +0000	[thread overview]
Message-ID: <1010602154909.ZM11443@candle.brasslantern.com> (raw)

In zsh-workers/14451, Andrej wrote:
} 
} On Wed, 23 May 2001, Oliver Kiddle wrote:
} 
} > x86 FreeBSD 4.2-stable
} >
} > make check yields several
} > /usr/libexec/ld-elf.so.1: Shared object "libzsh-4.0.1-pre-5.so" not found
} >
} > It seems that make check uses a `make install.modules' but libzsh is
} > installed as part of `make install.bin'. We need to fix this but I'm not
} > sure I fully understand this part of the Makefiles. Isn't this an issue
} > for cygwin?
} >
} 
} No, it was there long before. I suspect, that tests were never run on a
} system that needed libzsh (or already installed version was silently
} used).
} 
} Exactly on Cygwin it runs correctly, because it tries first to find DLL in
} the same directory as executable.

Does this patch fix it?  Unfortunately $(DLLD) is the only reasonable
symbol to test that is available in Test/Makefile; $(LIBZSH) is defined in
Src/Makefile.in only.  So this may needlessly export LD_LIBRARY_PATH on a
system that does not require libzsh, but that should be harmless, right?

Index: Test/Makefile.in
===================================================================
diff -c -r1.1.1.1 Test/Makefile.in
--- Test/Makefile.in	2001/04/09 20:14:14	1.1.1.1
+++ Test/Makefile.in	2001/06/02 15:29:29
@@ -45,7 +45,11 @@
 	  cd $(dir_top) && \
 	  $(MAKE) MODDIR=`pwd`/$(subdir)/Modules install.modules > /dev/null; \
 	fi
-	-for f in $(sdir)/$(TESTNUM)*.ztst; do \
+	-if test -n "$(DLLD)"; then \
+	  LD_LIBRARY_PATH="`cd $(dir_top); pwd`/Src:$$LD_LIBRARY_PATH"; \
+	  export LD_LIBRARY_PATH; \
+	fi; \
+	for f in $(sdir)/$(TESTNUM)*.ztst; do \
 	  $(dir_top)/Src/zsh +Z -f $(sdir)/ztst.zsh $$f; \
 	done
 	rm -rf Modules .zcompdump

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   


             reply	other threads:[~2001-06-02 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-02 15:49 Bart Schaefer [this message]
2001-06-02 17:48 ` Andrej Borsenkow
2001-06-03  0:52   ` Bart Schaefer
2001-06-03  8:40     ` Andrej Borsenkow
2001-06-03 18:04       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1010602154909.ZM11443@candle.brasslantern.com \
    --to=schaefer@candle.brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).