PATCH: _fc

PATCH: _fc

[Peter Stephenson]

Completion of options to `history' isn't working even after typing an
explicit `-' (this is reproducible with `zsh -f') and the reason seems to
be that the `*' arguments option is swallowing up all the `-' options.
For history, I can just omit the * part, but if I supply it for basic fc,
even as the last option, I still can't complete options, so something's
screwy.  I've had problems understanding what the * option does before.
Here's the only way I can get options to fc to complete at all, just
omitting *, but this clearly isn't right so I won't commit it.

Index: Completion/Zsh/Command/_fc
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Zsh/Command/_fc,v
retrieving revision 1.2
diff -u -r1.2 _fc
--- Completion/Zsh/Command/_fc	2001/04/11 21:47:18	1.2
+++ Completion/Zsh/Command/_fc	2001/06/04 11:41:27
@@ -4,8 +4,7 @@
 
 fc_common=(
   '(-A -R -W -I)-r[reverse order of the commands]'
-  '(-A -R -W -I -e)-n[suppress line numbers]'
-  '(-A -R -W -I)*::commands:_command_names -e' )
+  '(-A -R -W -I -e)-n[suppress line numbers]' )
 
 fc_hist=(
   '(-A -R -W -I)-m[treat first argument as a pattern]'

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************

Re: PATCH: _fc

[Bart Schaefer]

On Jun 4, 12:46pm, Peter Stephenson wrote:
} Subject: PATCH: _fc
}
} Completion of options to `history' isn't working even after typing an
} explicit `-' (this is reproducible with `zsh -f') and the reason seems to
} be that the `*' arguments option is swallowing up all the `-' options.

Back out 14607.  Same problem that's causing "make check" to fail.

I stared at _arguments but got lost and decided that just trying random
changes wasn't helpful.  Sven's back on Wednesday, I think.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net