From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>,
ZSH Workers Mailing List <zsh-workers@sunsite.dk>
Subject: Re: PATCH: "unimplemented" for test suite
Date: Mon, 18 Jun 2001 19:02:39 +0000 [thread overview]
Message-ID: <1010618190240.ZM16502@candle.brasslantern.com> (raw)
In-Reply-To: <Pine.SV4.4.33.0106182241440.17539-100000@itsrm2.mow.siemens.ru>
On Jun 18, 10:44pm, Andrej Borsenkow wrote:
}
} I was unsure about added value of this patch and there was no comments.
Certainly it would be nice to at least *explain* the test failures for
the Y* tests when --disable-dynamic ... either that, or we should add
zpty to the list of modules that are always linked by default.
Probably comptestinit should not proceed if zmodload zpty fails, and
the %prep section should fail in that case, so that we don't report
failures on individual tests.
If Andrej's patch -- or some combination of it with the below -- isn't
considered better, how about this?
diff -u zsh-forge/current/Test/Y01completion.ztst zsh-4.0/Test/Y01completion.ztst
--- zsh-forge/current/Test/Y01completion.ztst Mon Apr 2 05:35:14 2001
+++ zsh-4.0/Test/Y01completion.ztst Mon Jun 18 11:58:20 2001
@@ -6,12 +6,14 @@
mkdir comp.tmp
cd comp.tmp
- comptestinit -z $ZTST_testdir/../Src/zsh
+ comptestinit -z $ZTST_testdir/../Src/zsh && {
mkdir dir1
mkdir dir2
touch file1
touch file2
+
+ }
%test
diff -u zsh-forge/current/Test/Y02compmatch.ztst zsh-4.0/Test/Y02compmatch.ztst
--- zsh-forge/current/Test/Y02compmatch.ztst Mon Apr 2 05:35:31 2001
+++ zsh-4.0/Test/Y02compmatch.ztst Mon Jun 18 11:58:43 2001
@@ -16,7 +16,7 @@
mkdir match.tmp
cd match.tmp
- comptestinit -z $ZTST_testdir/../Src/zsh
+ comptestinit -z $ZTST_testdir/../Src/zsh && {
list1=(IndianRed IndianRed2 IndianRed3 IndianRed4)
test_code () {
@@ -33,7 +33,7 @@
comptesteval "$code"
}
-
+ }
diff -u zsh-forge/current/Test/Y03arguments.ztst zsh-4.0/Test/Y03arguments.ztst
--- zsh-forge/current/Test/Y03arguments.ztst Mon Apr 2 05:35:48 2001
+++ zsh-4.0/Test/Y03arguments.ztst Mon Jun 18 11:58:59 2001
@@ -6,9 +6,10 @@
mkdir comp.tmp
cd comp.tmp
- comptestinit -z $ZTST_testdir/../Src/zsh
+ comptestinit -z $ZTST_testdir/../Src/zsh && {
comptesteval 'compdef _tst tst'
tst_arguments () { comptesteval "_tst () { _arguments ${${(@qq)*}} }" }
+ }
%test
tst_arguments ':desc1:(arg1)'
diff -u zsh-forge/current/Test/comptest zsh-4.0/Test/comptest
--- zsh-forge/current/Test/comptest Sat Jun 9 10:24:31 2001
+++ zsh-4.0/Test/comptest Mon Jun 18 11:57:55 2001
@@ -5,7 +5,7 @@
$ZTST_srcdir/../Completion
$ZTST_srcdir/../Completion/*/*~*/CVS(/) )
- zmodload -i zsh/zpty
+ zmodload -i zsh/zpty || return $?
comptest_zsh=${ZSH:-zsh}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-06-18 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-13 8:01 Andrej Borsenkow
2001-06-18 18:04 ` Bart Schaefer
2001-06-18 18:44 ` Andrej Borsenkow
2001-06-18 19:02 ` Bart Schaefer [this message]
2001-06-18 19:09 ` Bart Schaefer
2001-06-26 14:52 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010618190240.ZM16502@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=Andrej.Borsenkow@mow.siemens.ru \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).