From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH: Re: Is PRINT_EXIT_VALUE supposed to work?
Date: Sun, 24 Jun 2001 04:06:35 +0000 [thread overview]
Message-ID: <1010624040635.ZM9031@candle.brasslantern.com> (raw)
In-Reply-To: <Tc0a88d015428e62ee9@mailsweeper01.cambridgesiliconradio.com>
On Jun 15, 2:22pm, Peter Stephenson wrote:
} Subject: Is PRINT_EXIT_VALUE supposed to work?
}
} I've never looked at this option until now, when I'm trying to write a
} test for it. It doesn't work with functions.
The simplest thing seems to be the patch below. I don't see any reason
to print the exit value of a builtin before flushing the stdout of that
builtin (though I also don't know of any case where it matters that the
stdout of the builtin gets flushed).
--- zsh-forge/current/Src/exec.c Sat Jun 23 11:24:32 2001
+++ zsh-4.0/Src/exec.c Sat Jun 23 20:53:45 2001
@@ -2288,9 +2288,6 @@
#ifdef PATH_DEV_FD
closem(2);
#endif
- if (isset(PRINTEXITVALUE) && isset(SHINSTDIN) && lastval && !subsh) {
- fprintf(stderr, "zsh: exit %ld\n", (long)lastval);
- }
fflush(stdout);
if (save[1] == -2) {
if (ferror(stdout)) {
@@ -2299,6 +2296,10 @@
}
} else
clearerr(stdout);
+ }
+ if (isset(PRINTEXITVALUE) && isset(SHINSTDIN) &&
+ lastval && !subsh) {
+ fprintf(stderr, "zsh: exit %ld\n", (long)lastval);
}
if (do_exec) {
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-06-24 4:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-15 13:22 Peter Stephenson
2001-06-24 4:06 ` Bart Schaefer [this message]
2001-07-03 17:13 ` PATCH: " Peter Stephenson
2001-07-03 17:46 ` Bart Schaefer
2001-07-08 15:19 ` Bart Schaefer
2001-07-09 8:22 ` Sven Wischnowsky
2001-07-09 11:08 ` PATCH: doshfunc() Bart Schaefer
2001-07-09 11:28 ` PATCH: doshfunc Sven Wischnowsky
2001-07-09 16:11 ` Bart Schaefer
2001-07-10 9:42 ` Sven Wischnowsky
2001-07-10 16:06 ` Bart Schaefer
2001-07-11 7:18 ` Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010624040635.ZM9031@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).