Parameters are being typed as float by default?

Parameters are being typed as float by default?

[Bart Schaefer]

This has something to do with 15291, 15292.  In my .zshrc is the snippet

    FP='?f%f:.?a :.(?eEND:?pb%pb\%:?abyte :.%bb..)?e?x - Next\: %x:.:.$'
    LESS="a mPm$FP q X"		# Less version 332
    let lines=$LINES-2
    export LESS="$LESS z$lines"

If I then "echo $LESS" I see

a mPm?f%f:.?a :.(?eEND:?pb%pb\%:?abyte :.%bb..)?e?x - Next\: %x:.:.$ q X z22.0000000000

I really didn't want that .0000000000 in there; it causes less to complain
that there's "no -. option".  Why did $lines become float-typed?  And can 
you please make it stop?


-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: Parameters are being typed as float by default?

[Bart Schaefer]

On Jul 7,  4:06pm, Bart Schaefer wrote:
} Subject: Parameters are being typed as float by default?
}
} This has something to do with 15291, 15292.
}
}     let lines=$LINES-2
} 
} Why did $lines become float-typed?

It became float-typed because at math.c:644, MN_UNSET != MN_INTEGER, so
the types of both the integer and the unset parameter got coerced to float.

However, I don't know the right way to fix this.  I'm pretty sure that
MN_UNSET should not be changed to MN_INTEGER at that point in the code.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: Parameters are being typed as float by default?

[Bart Schaefer]

On Jul 7,  4:43pm, Bart Schaefer wrote:
} }
} }     let lines=$LINES-2
} } 
} } Why did $lines become float-typed?
} 
} It became float-typed because at math.c:644, MN_UNSET != MN_INTEGER
} 
} However, I don't know the right way to fix this.

After some further study, the following seems to be sufficient, because
`a' is never referenced again on `EQ'.  Peter?

--- zsh-forge/current/Src/math.c	Fri Jul  6 20:16:59 2001
+++ zsh-4.0/Src/math.c	Sat Jul  7 12:21:13 2001
@@ -641,7 +641,8 @@
 		b.type = MN_INTEGER;
 		b.u.l = (zlong)b.u.d;
 	    }
-	} else if (a.type != b.type && what != COMMA) {
+	} else if (a.type != b.type && what != COMMA &&
+		   (a.type != MN_UNSET || what != EQ)) {
 	    /*
 	     * Different types, so coerce to float.
 	     * It may happen during an assigment that the LHS

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: Parameters are being typed as float by default?

[Peter Stephenson]

"Bart Schaefer" wrote:
> On Jul 7,  4:43pm, Bart Schaefer wrote:
> } }
> } }     let lines=$LINES-2
> } } 
> } } Why did $lines become float-typed?
> } 
> } It became float-typed because at math.c:644, MN_UNSET != MN_INTEGER
> } 
> } However, I don't know the right way to fix this.
> 
> After some further study, the following seems to be sufficient, because
> `a' is never referenced again on `EQ'.  Peter?

That looks fine.  In fact, (a.type != MN_UNSET) should be enough, because
it will always be marked as unset if (what == EQ), but I wouldn't lose
sleep over that.

I looked to see if this is going to have further ramifications since
there's no type coercion until the actual point of setting, but I couldn't
find a case where it makes a difference (this almost is the point of
setting, since that's all that equals does apart from returning the
value/type just set).

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk