From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: PATCH: Re: 4.0.1 (and 4.1.0) infinite loop with history
Date: Sun, 8 Jul 2001 00:05:48 +0000 [thread overview]
Message-ID: <1010708000549.ZM17484@candle.brasslantern.com> (raw)
In-Reply-To: <1010707231600.ZM16868@candle.brasslantern.com>
On Jul 7, 11:15pm, Bart Schaefer wrote:
} Subject: 4.0.1 (and 4.1.0) infinite loop with history
}
} ... all you need to do is fill up the history (so that event
} number 1 will fall off the saved lines) and then give the command `r = 1'.
Happens in 3.0.6 through 3.0.8 as well. And -- good grief -- even in 2.4.
And the history number is a red herring: The loop appears to be attempting
to globally replace the empty string with the empty string, i.e. the `='
is being taken as a degenerate case of OLD=NEW.
Consequently, this should fix it:
Index: Src/builtin.c
===================================================================
diff -c -r1.4 Src/builtin.c
--- Src/builtin.c 2001/06/18 18:01:56 1.4
+++ Src/builtin.c 2001/07/08 00:02:51
@@ -1250,6 +1250,10 @@
while (*argv && equalsplit(*argv, &s)) {
Asgment a = (Asgment) zhalloc(sizeof *a);
+ if (!**argv) {
+ zwarnnam(nam, "invalid replacement pattern: =%s", s, 0);
+ return 1;
+ }
if (!asgf)
asgf = asgl = a;
else {
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
prev parent reply other threads:[~2001-07-08 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-07 23:15 Bart Schaefer
2001-07-08 0:05 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010708000549.ZM17484@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).