From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: Re: Is PRINT_EXIT_VALUE supposed to work?
Date: Sun, 8 Jul 2001 15:19:32 +0000 [thread overview]
Message-ID: <1010708151933.ZM18654@candle.brasslantern.com> (raw)
In-Reply-To: <Tc0a88d0154866d381d@mailsweeper01.cambridgesiliconradio.com>
On Jul 3, 6:13pm, Peter Stephenson wrote:
} Subject: Re: PATCH: Re: Is PRINT_EXIT_VALUE supposed to work?
}
} I've been a long time getting around to looking at this, but does this
} really work?
}
} zsh -c 'setopt printexitvalue; fn() { false;}; fn'
This works for me now:
schaefer[652] Src/zsh -fc 'setopt printexitvalue; fn() { false;}; fn'
zsh: exit 1
schaefer[653] Src/zsh -fc 'fn() { false;}; fn'
schaefer[654]
I can't see anything that might have changed since 15057 that would have
affected this, but there it is.
Meanwhile, I think I've spotted a bug in doshfunc(). Can someone explain
why the following (or something better that doesn't use `goto') is not
necessary? (I won't commit it until I get second opinions from Sven and
PWS.)
Index: Src/exec.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/exec.c,v
retrieving revision 1.7
diff -c -r1.7 exec.c
--- exec.c 2001/06/28 08:40:25 1.7
+++ exec.c 2001/07/08 15:17:02
@@ -3359,9 +3359,7 @@
if(++funcdepth > MAX_FUNCTION_DEPTH)
{
zerr("maximum nested function level reached", NULL, 0);
- scriptname = oldscriptname;
- popheap();
- return;
+ goto undoshfunc;
}
#endif
fstack.name = dupstring(name);
@@ -3382,14 +3380,14 @@
errflag = 1;
else
lastval = 1;
- popheap();
- scriptname = oldscriptname;
- return;
+ goto doneshfunc;
}
prog = shf->funcdef;
}
runshfunc(prog, wrappers, fstack.name);
+ doneshfunc:
funcstack = fstack.prev;
+ undoshfunc:
#ifdef MAX_FUNCTION_DEPTH
--funcdepth;
#endif
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-07-08 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-15 13:22 Peter Stephenson
2001-06-24 4:06 ` PATCH: " Bart Schaefer
2001-07-03 17:13 ` Peter Stephenson
2001-07-03 17:46 ` Bart Schaefer
2001-07-08 15:19 ` Bart Schaefer [this message]
2001-07-09 8:22 ` Sven Wischnowsky
2001-07-09 11:08 ` PATCH: doshfunc() Bart Schaefer
2001-07-09 11:28 ` PATCH: doshfunc Sven Wischnowsky
2001-07-09 16:11 ` Bart Schaefer
2001-07-10 9:42 ` Sven Wischnowsky
2001-07-10 16:06 ` Bart Schaefer
2001-07-11 7:18 ` Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010708151933.ZM18654@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).