From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23556 invoked from network); 15 Sep 2001 04:51:03 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 15 Sep 2001 04:51:03 -0000 Received: (qmail 14488 invoked by alias); 15 Sep 2001 04:50:56 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 15808 Received: (qmail 14473 invoked from network); 15 Sep 2001 04:50:54 -0000 From: Bart Schaefer Message-Id: <1010915044927.ZM986@candle.brasslantern.com> Date: Sat, 15 Sep 2001 04:49:27 +0000 In-Reply-To: Comments: In reply to Wayne Davison "Re: r problem" (Sep 13, 5:52pm) References: X-Mailer: Z-Mail (5.0.0 30July97) To: Zsh Workers Subject: Re: r problem MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Sep 13, 5:52pm, Wayne Davison wrote: } } One potential solution to this would be to change the history-line-drop } code to lookup "r" in a function list and avoid dropping "r" (but not } "builtin r") if we find it. I don't know the function code well enough } to know if there is an inexpensive call that should_ignore_line() could } call for this or not. It's just a hash lookup: if (shfunctab->getnode(shfunctab, "r")) { /* It's a function */ } As it would only be happening after the command name had already been compared to (fc|history|r), I don't think it's prohibitively expensive, though it's exactly what exec.c is going to be doing a few instructions later. -- Bart Schaefer Brass Lantern Enterprises http://www.well.com/user/barts http://www.brasslantern.com Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net