_path_files problem: completion for "cvs commit" has stopped working

_path_files problem: completion for "cvs commit" has stopped working

[Bart Schaefer]

I apologize for not noticing this sooner, as it appears to date back to
July -- Sven's change to _path_files in 15389.

In 4.0.1 up through the head of the -patches branch, I can do this:

schaefer[502] cvs commit Completion/Unix/Command/_m<TAB>
schaefer[502] cvs commit Completion/Unix/Command/_mount

That is, it completes to exactly the file that has changed, ignoring all
the other _m* files in Completion/Unix/Command/.

In 4.1.0-dev-2, I get this:

schaefer<504> cvs commit Completion/Unix/Command/_m<TAB>                          
Completing file
_mount         _modutils*     _mail          _mh                         
_man           _mutt          _mysql_utils   _make                       

Needless to say, I don't like this at all.  The _complete_debug traces are
identical up to this point:

@@ -903,11 +905,11 @@
 : _all_labels:39:while else; _path_files -J directories -X Completing directory -g *~(*/|)CVS(/)
 : _path_files:6; local linepath realpath donepath prepath testpath exppath skips skipped
 : _path_files:7; local tmp1 tmp2 tmp3 tmp4 i orig eorig pre suf tpre tsuf opre osuf cpre
-: _path_files:8; local pats haspats ignore pfxsfx sopt gopt opt sdirs ignpar cfopt listsfx
+: _path_files:8; local pats haspats ignore pfx pfxsfx sopt gopt opt sdirs ignpar cfopt listsfx
 : _path_files:9; local nm=0 menu matcher mopts sort match mid accex fake
 : _path_files:11; typeset -U prepaths exppaths
 : _path_files:13; exppaths=( ) 
-: _path_files:17; zparseopts -a mopts P:=pfxsfx S:=pfxsfx q=pfxsfx r:=pfxsfx R:=pfxsfx W:=prepaths F:=ignore M+:=matcher J+: V+: X+: 1: 2: n: f=tmp1 /=tmp1 g+:-=tmp1
+: _path_files:17; zparseopts -a mopts P:=pfx S:=pfxsfx q=pfxsfx r:=pfxsfx R:=pfxsfx W:=prepaths F:=ignore M+:=matcher J+: V+: X+: 1 2 n f=tmp1 /=tmp1 g+:-=tmp1
 : _path_files:22; sopt=-g 
 : _path_files:23; ((  1  ))
 : _path_files:23:cmdand; haspats=yes 


-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: _path_files problem: completion for "cvs commit" has stopped working

[Sven Wischnowsky]

Bart Schaefer wrote:

> ...
> 
> In 4.0.1 up through the head of the -patches branch, I can do this:
> 
> schaefer[502] cvs commit Completion/Unix/Command/_m<TAB>
> schaefer[502] cvs commit Completion/Unix/Command/_mount
> 
> That is, it completes to exactly the file that has changed, ignoring all
> the other _m* files in Completion/Unix/Command/.
> 
> In 4.1.0-dev-2, I get this:
> 
> schaefer<504> cvs commit Completion/Unix/Command/_m<TAB>                          
> Completing file
> _mount         _modutils*     _mail          _mh                         
> _man           _mutt          _mysql_utils   _make                       

I got the same when I tried it with a 4.0-branch-shell without the
stat module. In that case _cvs_modified_entries only calls
_cvs_existing_entries.

May that be your problem? With the stat module it works fine for me.


Bye
  Sven

-- 
Sven Wischnowsky                    wischnow@informatik.hu-berlin.de

Re: _path_files problem: completion for "cvs commit" has stopped working

[Bart Schaefer]

On Oct 17,  1:45pm, Sven Wischnowsky wrote:
} 
} Bart Schaefer wrote:
} 
} > In 4.1.0-dev-2, I get this:
} > 
} > schaefer<504> cvs commit Completion/Unix/Command/_m<TAB> 
} > Completing file
} > _mount         _modutils*     _mail          _mh                         
} > _man           _mutt          _mysql_utils   _make                       
} 
} I got the same when I tried it with a 4.0-branch-shell without the
} stat module. In that case _cvs_modified_entries only calls
} _cvs_existing_entries.

Argh.

Is it worth pointing out that this is the only place where the completion
system relies on a module that is not by default linked into a static zsh?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: _path_files problem: completion for "cvs commit" has stopped working

[Sven Wischnowsky]

Bart Schaefer wrote:

> ...
> 
> Is it worth pointing out that this is the only place where the completion
> system relies on a module that is not by default linked into a static zsh?

Yes, I had the strong feeling that we should do that, too.  but I
didn't know where and how.


Bye
  Sven

-- 
Sven Wischnowsky                    wischnow@informatik.hu-berlin.de