From: Bart Schaefer <schaefer@brasslantern.com>
To: "'Zsh hackers list'" <zsh-workers@sunsite.dk>
Subject: PATCH: Infinite loop in `case' with xtrace
Date: Tue, 23 Oct 2001 15:19:22 +0000 [thread overview]
Message-ID: <1011023151922.ZM18848@candle.brasslantern.com> (raw)
In-Reply-To: <000801c15bcb$1500b0a0$21c9ca95@mow.siemens.ru>
(Read all the way to the end, there are comments interspersed with patches.)
I just did
zsh% zstyle \* preserve-prefix \~///
zsh% ls ~///<C-x ?>
and _arguments went into an infinite loop. At first I thought it was this:
Index: Completion/Base/Utility/_arguments
===================================================================
--- Completion/Base/Utility/_arguments 2001/09/05 15:22:28 1.6
+++ Completion/Base/Utility/_arguments 2001/10/23 14:56:53
@@ -183,6 +183,7 @@
-w) optarg=yes; shift;;
-s) singopt=(-s); shift;;
-W) alwopt=arg; shift;;
+ *) break;;
esac
done
But when that didn't fix it I found it was really this, caused by 16041:
Index: Src/loop.c
===================================================================
--- Src/loop.c 2001/10/17 14:38:28 1.3
+++ Src/loop.c 2001/10/23 15:09:50
@@ -553,9 +553,8 @@
printprompt4();
fprintf(xtrerr, "case %s (%s)\n", word, pat2);
fflush(xtrerr);
- state->pc++;
- } else
- state->pc += 2;
+ }
+ state->pc += 2;
if (*spprog != dummy_patprog1 && *spprog != dummy_patprog2)
pprog = *spprog;
I note that neither 16038 nor 16041 has been applied to the 4-0-patches
branch. Are they not needed there? (And if 16041 is needed, be sure to
apply the above as well.)
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
prev parent reply other threads:[~2001-10-23 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-22 14:48 PATCH: Constant initial fdtable_size Bart Schaefer
2001-10-22 14:57 ` Peter Stephenson
2001-10-22 15:17 ` Anything left (Re: PATCH: Constant initial fdtable_size) Bart Schaefer
2001-10-22 15:37 ` Bart Schaefer
2001-10-22 16:57 ` Oliver Kiddle
2001-10-22 17:09 ` Peter Stephenson
2001-10-23 6:03 ` Borsenkow Andrej
2001-10-23 14:00 ` Borsenkow Andrej
2001-10-23 15:19 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011023151922.ZM18848@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).