From: Bart Schaefer <schaefer@brasslantern.com>
To: Carl Feynman <carlf@abinitio.com>, zsh-workers@sunsite.dk
Subject: PATCH (4.0.x, 4.1.x): Re: Core dump bug in ZSH version 3.0.7
Date: Tue, 13 Nov 2001 18:21:14 +0000 [thread overview]
Message-ID: <1011113182115.ZM20682@candle.brasslantern.com> (raw)
In-Reply-To: <1011112185944.ZM19128@candle.brasslantern.com>
On Nov 12, 6:59pm, Bart Schaefer wrote:
} Subject: Re: Core dump bug in ZSH version 3.0.7
}
} It doesn't crash 4.0.x/4.1.x, but it does get into a rather strange state,
} trying to read a here-document whose start/end string is a single space,
} which of course is impossible (so you're trapped in the here-document until
} you interrupt somehow).
}
} zagzig% mask = (1 << string.atoi(sys.argv[1])) - 1
} zsh: parse error near `)'
At this point we've parsed this as the command "mask" with arguments "="
and "(1" and with here-document ending at "string.atoi(sys.argv[1])"; the
parse error is at the second parenthesis.
However, when zsh bailed out with the parse error, it failed to pop the
pending here-document off the queue of such documents. So then when it
begins parsing this:
} zagzig% key = string.atoi(sys.argv[2])
} heredoc>
Zsh now believes it is accepting input for the here-document started at
the previous command line. 4.0+ doesn't crash because it re-uses the
memory at which the here-document's name is pointing, so the document
merely seems to have a bogus name; 3.0.x crashes because the name pointer
in the here-document structure has become garbage.
The solution seems to be the following; I haven't checked whether it will
apply directly to 3.0.x, as this patch is based on 4.1.0-dev-2:
Index: Src/parse.c
===================================================================
--- Src/parse.c 2001/09/05 15:22:33 1.10
+++ Src/parse.c 2001/11/13 18:10:10
@@ -481,6 +481,11 @@
return 0;
}
yyerror(1);
+ while (hdocs) {
+ struct heredocs *next = hdocs->next;
+ zfree(hdocs, sizeof(struct heredocs));
+ hdocs = next;
+ }
herrflush();
if (noerrs != 2)
errflag = 1;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-11-13 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-12 18:28 Carl Feynman
2001-11-12 18:59 ` Bart Schaefer
2001-11-13 18:21 ` Bart Schaefer [this message]
2001-11-14 8:57 PATCH (4.0.x, 4.1.x): " Wischnowsky, Sven
2001-11-15 5:38 ` Bart Schaefer
2001-11-15 8:13 Wischnowsky, Sven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011113182115.ZM20682@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=carlf@abinitio.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).