From: Bart Schaefer <schaefer@brasslantern.com>
To: "Wischnowsky, Sven" <Sven.Wischnowsky@t-systems.de>,
zsh-workers@sunsite.dk
Subject: Re: [bug report] 4.0.2 / 4.0.4 dumps core
Date: Wed, 21 Nov 2001 18:35:19 +0000 [thread overview]
Message-ID: <1011121183520.ZM2506@candle.brasslantern.com> (raw)
In-Reply-To: <7D865FB0D0A1D5118B6E000347055BBB148483@G9JNT.mgb01.telekom.de>
On Nov 15, 9:16am, Wischnowsky, Sven wrote:
}
} > > schaefer[524] Src/zsh -f
} > > zagzig% setopt extendedglob globcomplete nobanghist
} > > zagzig% !^<TAB>zsh: segmentation fault (core dumped) Src/zsh -f
}
} Here's that patch.
}
} Bye
} Sven
}
} diff -ur ../oz/Src/hashtable.c ./Src/hashtable.c
} --- ../oz/Src/hashtable.c Tue Nov 13 19:13:45 2001
} +++ ./Src/hashtable.c Tue Nov 13 19:26:12 2001
} @@ -975,7 +975,7 @@
} reswdtab->printnode = printreswdnode;
}
} for (rw = reswds; rw->nam; rw++)
} - reswdtab->addnode(reswdtab, rw->nam, rw);
} + reswdtab->addnode(reswdtab, ztrdup(rw->nam), rw);
} }
}
} /* Print a reserved word */
}-- End of excerpt from Wischnowsky, Sven
I'm wondering if it wouldn't be more appropriate to duplicate the strings
in compctl.c:dumphashtable() rather than simply allowing the completion
code to poke bytes into the real reswdtab.
E.g.:
Index: Src/Zle/compctl.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/Zle/compctl.c,v
retrieving revision 1.2
diff -c -r1.2 compctl.c
--- Src/Zle/compctl.c 2001/04/10 16:37:32 1.2
+++ Src/Zle/compctl.c 2001/11/21 17:00:03
@@ -2096,7 +2096,7 @@
for (i = 0; i < ht->hsize; i++)
for (hn = ht->nodes[i]; hn; hn = hn->next)
- addmatch(hn->nam, (char *) hn);
+ addmatch(dupstring(hn->nam), (char *) hn);
}
/* ScanFunc used by maketildelist() et al. */
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2001-11-21 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-15 8:16 Wischnowsky, Sven
2001-11-21 18:35 ` Bart Schaefer [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-11-23 8:13 Wischnowsky, Sven
2001-11-22 8:09 Wischnowsky, Sven
2001-11-22 17:56 ` Bart Schaefer
2001-11-14 9:03 Wischnowsky, Sven
2001-11-12 2:39 Akitoshi MORISHIMA
2001-11-12 9:10 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011121183520.ZM2506@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=Sven.Wischnowsky@t-systems.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).